view · edit · sidebar · attach · print · history

Index>

20140506-oddb2xml

Summary

  • Fix wrong SALECD-field with oddb2xml
  • Pretty FI in oddb2xml

Commits

Index

Keep in Mind

---

Pretty FI in oddb2xml

The following classes must be extracted from oddb.org

  • src/model/text
  • src/model/fachinfo
  • ext/fiparse/textinfo_hpricot
  • ext/fiparse/fachinfo_hpricot
  • ext/fiparse/fiparse
  • ext/fiparse/writer

In a first step we will create a subdir fi in lib/oddb2xml (and spec/) to easen a later extraction to a separate gem.

We will add an option --extract-fi [iksrn1,iksrn2,..] to extract all fachinfo.

We will use some of the more difficult FIs to verify our work. They must contain

  1. tables
  2. images
  3. illegal image content
  4. spaces
  5. bold
  6. italic
  7. special characters

Candidates are 45928 (Künzle), 62184 (Cipralex® Filmtabletten), 58267 for Isentress.

Fix wrong SALECD-field with oddb2xml

Continue work refactoring. Compressor does no longer work when using other directory. Is it a good spec test? Yes. But working in another directory needs a few changes. Also moved all used compressed files from spec/data to spec/data/compressor. Pushed commit Reworked skip-download and rspec to not touch downloads

Coming back to my original task. Fix salescd for zurRose. Added rspec test for duplicate pharmacode 5366964. Fix was quite easy and time to run the -e options dropped to less than 4 minutes. No idea, why. Rspec passes now. Running rake test and comparing results.

Comparing the results I see that the fields DSCRD, DSCRF and CPTCMP are missing for 7680353660163 in oddb_product.xml (-a nonpharma). oddb_substance.xml hat only 10 substances instead of 1455. Also only 4 instead of 897 limitations.

In oddb_article.xlm I have (as expected new NINCD of 99 for zurRose). But missing are the fielss SYN1D SYN1F and SLOPLUS. Also for PHARMA 0020273 I did not have prices. Reason was, that rake spec left a small file XMLPublications.zip. Fixed the error. Now building take again about 15 minutes.

Modifying test_options.rb to skip some long running test when on travis.

Pushed commit Reworked skip-download and rspec to not touch downloads

I still have dummy NINCD with value 99. Fixing this problem locally and running rake test again, which will take about 2000 seconds (or more than 30 minutes) to run oddb2xml -e.

Pushed changes. But I still have an error after a closer look at the oddb_product.xml. The field PRODNO is not defined anymore. And was not checked for in any rspec test.

Fixed the problem with commit https://github.com/ngiger/oddb2xml/commit/5a2884740e9c2f0d4dadb35fb5a3e6991719bcc2 Corrected parsing orphan/fridges. Added rspec tests

Removed unused files in spec/data and made rspec more robust with commit Cleanup rspec

view · edit · sidebar · attach · print · history
Page last modified on May 06, 2014, at 10:14 PM