Index>

220150427-oddb2xml-correct-names-from-IGM-11

Summary

• Fix wrong charset and trailing white space issue in oddb2xml
• Switch parsing composition for --calc in oddb2xml to use parslet

Commits

in branch version/2.0.6

• https://github.com/ngiger/oddb2xml/commit/3c701bfedacc5d0e758c0f78a1ac0db21c1d473e Remove trailing spaces in names coming from ZurRose
• https://github.com/ngiger/oddb2xml/commit/31256b383269155c8262c6bb167edf1810a17e26 Use ISO-8859-14 to read zurrose transfer.dat. Fix 3 non UTF-8 chars.
• https://github.com/ngiger/oddb2xml/commit/b051c1a55f0a167655d321ae654dce3aaf20a263 Bump version to 2.0.6
• https://github.com/ngiger/oddb2xml/commit/354855b23fb165c236c47b17acd7a7daee9a8b29 Fix builder_spec

in master branch

• https://github.com/ngiger/oddb2xml/commit/50e9fb651f9a42d2445fd1b79132b3e3f711da7f Remove trailing spaces in names coming from ZurRose
• https://github.com/ngiger/oddb2xml/commit/991eec6f1e1c01d8bf974ac15f7789420e2a7e01 Fix handling polysorbatum, 10^4.4, 'q.s.'
• https://github.com/ngiger/oddb2xml/commit/ec930fbec04bd41d6a0fedea068986cdf91a6d3f Handle various rarely occurent doses and substance names
• https://github.com/ngiger/oddb2xml/commit/9a8d9cc0f49c8bc033bbfafafc683c2f0cd59fe1 Handle cryodesiccata and Telum
• https://github.com/ngiger/oddb2xml/commit/38a7c37aa772bb1e302cb45fb053002f133469a2 Added more units. Handle '150 U.I. hFSH et 150 U.I. hLH' and potenziert
• https://github.com/ngiger/oddb2xml/commit/0ef7dfc4189ce051931903e60bfa51c821143275 Fix issue with ',' and 'spec.'
• https://github.com/ngiger/oddb2xml/commit/f1518afaa73cf2d51cf147b9de5fd37b26154a46 Improve reporting of oddb --calc
• https://github.com/ngiger/oddb2xml/commit/2d8454e9035435aee4366e2de8cac515d4e25084 Fixed various errors, eg. 2,2'-methylen-bis(6-tert.-butyl-4-methyl-phenolum)
• https://github.com/ngiger/oddb2xml/commit/e4f89240c6017859c332f8e42209131c68a8ec5e Added reporting handling SwissMedicErrors

Index

• Fix wrong charset and trailing white space issue in oddb2xml
• Switch parsing composition for --calc in oddb2xml to use parslet

Keep in Mind for work to do

• Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
• I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
• The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
• creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
• Import via data/medreg_companies.yaml
• Fix problem with radioactivatum 99m-technetio when parsing Wirkstoffe

Fix wrong charset and trailing white space issue in oddb2xml

When importing products from IGM-11 files from zur Rose we should

• take only name of product, not full descriptition (see issue 16 https://github.com/zdavatz/oddb2xml/issues/16)
• remove multiple occurrences of white-space

Pushed commit Remove trailing spaces in names coming from ZurRose

Looking at the problem that we have sometimes weird characters in the output file. I think we probably don't open the transfer.dat with the correct encoding (ISO-8859-14). But afterwards we have to explitely encode each line as UTF-8 go fix this problem. This problem got unnoticed as for the normal umlauts like üüö the UTF-8 encoding is the same as ISO-8859-1.

Opened a new branch version/2.0.6 because I don't want to switch using parslet in a release version of oddb2xml

• Remove trailing spaces in names coming from ZurRose
• Use ISO-8859-14 to read zurrose transfer.dat. Fix 3 non UTF-8 chars.
• Bump version to 2.0.6

Travis-CI reminded me to fix 3 failing specs. Done with commit Fix builder_spec

Switch parsing composition for --calc in oddb2xml to use parslet

Stuff to do today includes:

• handle correctly all occurrences of corresp.
• Fix up/lowercase issues for substance names
• Fix various issues in code and spec tests marked TODO
• document design and decisions (2 or 3 pages in textile format, giving IKSNR/names for various examples)
  • what is the meaning of DER?
  • shall excipiens and friends be a normal substance? But their quantity "pro" is used for various measures?
  • Howto handle stuff like Praeparatio cryodesiccata
• Selling units for 7680611860045 should be 5 and not 12500
• Substance name 7680656280013 for is Vipera Aspis > 1000 Ld50 Mus and must be corrected to Vipera Aspis > 1000 Ld50 Mus
• IKNSR 7680616310026 does not creat a corret label A

Pushed all commits made during last days to bring down number of failing lines to 0 when discarding those which contains corresp.