Index>
20150429-oddb2xml-with-parslet
Summary
- Switch parsing composition for --calc in oddb2xml to use parslet
- Remove dosis info from galenic_form
Commits
Index
- Keep in Mind for work to do
-
- Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
- I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
- The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
- creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
- Import via data/medreg_companies.yaml
- Fix problem with radioactivatum 99m-technetio when parsing Wirkstoffe
- Fix galenic_forms when parsing swissmedic.xlsx
Remove dosis info from galenic_form
Currently we have 176 occurences of at least one digit in galenic_form. E.g. are 5 cm, 100 ug Inhalationspulver, solution injectable (vials à 50 ml), Infusionskonzentrat 1000ug/10ml, Infusionskonzentrat 1000ug/10ml or Gel 500 mcg/g. We should get rid of them.
But some galenic_forms are not generated correctly. E.g for Ricola Kräuter, Kräuterbonbons ohne Zucker, 3,6 g wie exctracted 6 g, but logically it should be Kräuterbonbons ohne Zucker. Maybe I should extend the parslet-parser to parse this field, too.
Switch parsing composition for --calc in oddb2xml to use parslet
Stuff to do today includes:
- handle correctly all occurrences of corresp.
- Fix up/lowercase issues for substance names
- Fix various issues in code and spec tests marked
TODO
- document design and decisions (2 or 3 pages in textile format, giving IKSNR/names for various examples)
what is the meaning of DER? DER = Drug Extract Ratio (Drogen-Extrakt-Verhältnis).
Selling units for 7680611860045 should be 5 and not 12500
Substance name 7680656280013 for is Vipera Aspis > 1000 Ld50 Mus and must be corrected to Vipera Aspis > 1000 Ld50 Mus. NO! This is normal XML-encoding.
Correcting/expanding generation of XML file. Include salts. Fix errors in spec/calc_spec.rb.
Updated documentation. Bumped version to 2.0.7. Now running test_options.rb which will take an hour or two to finish.
Pushed various commits. oddb2xml --calc looks now a lot better.
Travis-CI reminded me to fix some errors and to make the spec output less verbose. Hope that after commit Fixed failing composition specs travis-CI will be happy.
Pushed commits