view · edit · sidebar · attach · print · history

< Niklaus.20160301-fix-import-daily | Index | Niklaus.20160224-fix-import-daily >>

20160229-fi-with-wrong-language

Summary

  • FI and changelog of newly imported FI has wrong language

Commits

Index

Keep in Mind for work to do
  • Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
  • I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
  • The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
  • creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
  • Import via data/medreg_companies.yaml
  • Fix problem with radioactivatum 99m-technetio when parsing Wirkstoffe
  • Fix galenic_forms when parsing swissmedic.xlsx
  • Cleanup generic_type. Replace it everywhere by sl_generic_type and adapt code accordingly.
  • Get updated ATC-codes from EPha for oddb.org, too.
  • Use refdatabase for oddb.org, too.
  • Check whether we should revert the part which touche src/plugin/text_info.rb of commit 17af82ba4d76a5838683411b260de265531f9e74. We should improve test/stub/oddbapp.rb to work similar for update/pointer as the real oddbapp. In this case we would have a good Stub for plugins. May we need a different stub when working with plugins (which create/modify/destroy ODDB-Objects), when in most other cases a very simple stub is sufficient.
  • When a logged in admin user changes an atc_code of a product, the corresponding atc_class must update its sequences, too.
  • Order of entering search type and value should not matter. Both should show long URL with search
  • Remove parser for minifi (but keep the minifi)

FI and changelog of newly imported FI has wrong language

E.g.

Looking at this adress and the french/italian correspondance shows that [de|fr|it]/gcc/fachinfo/reg/65781 always displays the german text, but [de|fr|it]/gcc/show/fachinfo/65460/diff/25.02.2016 only show the french diffs. Something got messed up.

Why did the patinfo of 65781 and 65460 got reparsed 4 times in the last 4 days? Must have a closer look at the logs. 65460 is also mentined in the refdata mail of 10/2015.

bin/admin shows, that the patinfo was not created correctly

ch.oddb> registration('65460').sequence('01').packages.values.first.patinfo.class
-> NilClass
ch.oddb> 

Therefore it does not appear on http://ch.oddb.org/de/gcc/show/state_id/260627380/reg/65460/seq/01/pack/001

Now looking at the FI text

ch.oddb> registration('65460').fachinfo.de.text[0..80]
-> Composition
Principe actif:
Lactab, Solution buvable en gouttes: Escitalopramum u
ch.oddb> 
-> 
ch.oddb> registration('65460').fachinfo.fr.text[0..80]
-> Composition
Principe actif:
Lactab, Solution buvable en gouttes: Escitalopramum u
ch.oddb> 
-> 
ch.oddb> registration('65460').fachinfo.it.text[0..80]
-> Composition
Principe actif:
Lactab, Solution buvable en gouttes: Escitalopramum u

The method to store patinfo where there is only one in a registration failed. Fixing it. After many tries, the patinfo finally get updated correctly.

After running jobs/update_textinfo_swissmedicinfo --reparse --target=both 65460. But the fachinfo changelog dit not get updated correctly.

Reloading the old database to check whether the fachinfo gets updated correctly now. Running the import now again. Got an error Message: undefined method `err' for #<TypeError: can't dump File>. Can I avoid this using GC.disable/enable?

Fixed another error when updating the change_info for a fachinfo.

view · edit · sidebar · attach · print · history
Page last modified on March 01, 2016, at 08:09 AM