view · edit · sidebar · attach · print · history

< Niklaus.20171129-oddb-redesign | Index | Niklaus.20171127-oddb-redesign >>

20171128-oddb-redesign

Summary

Commits

Index

Fix some design details

TODO items are:

  • Remove additional line in interaction between Zulassunginhaber und "Sie befinden sich in"
  • Move "Für den Direktvergleich" after the list of Drugs
  • Logo is centered when one wants to pay as PowerUser
  • Google add is missing in when asking for paypal
  • Add "Für den Direktvergleich" also in the price comparision view
  • Google-Tracking-Code for Just-Medical
  • Remove facebook link from migel result
  • Remove everywhere function to create receipts
  • Make unit tests pass travis-ci

Pushed commit Search drugs: align backracking and search button

To fix the wrong alignment when asking for the poweruser login I found it was easy to add a check in the watir test to check the top left alignment of the ODDB logo with the following snippet

    expect(@browser.images.first.wd.location.x).to be < 20
    expect(@browser.images.first.wd.location.y).to be < 20

Pushed commits

Must remove the facebook link in Migel. Done with commit Don't show facebook in migel result

Fixed unit tests with

Now travis-ci turned green! Nice.

Working on removing the prescription. Running all unit tests before committing the changes. The unit tests passed.

Now fixing the spec test to remove the prescription relates tests. Running all watir tests, to check for problems introduced by the removal of prescription.

I have 27 problems

rspec ./spec/download_spec.rb:55 # ch.oddb.org should be possible to download Zulassungsinhaber Desitin as admin user
rspec ./spec/evidentia_spec.rb:61 # ch.oddb.org should list C09DB02 before C09DX03 when looking for Sevikar
rspec ./spec/evidentia_spec.rb:72 # ch.oddb.org should list Keppra at the top when searching for Levetiracetam
rspec ./spec/evidentia_spec.rb:77 # ch.oddb.org should list Levetiracetam Desitin at the top when searching for Levetiracetam Desitin
rspec ./spec/evidentia_spec.rb:83 # ch.oddb.org should list all SL products before the Non-SL
rspec ./spec/evidentia_spec.rb:104 # ch.oddb.org should not contain a column Fachinfo
rspec ./spec/evidentia_spec.rb:117 # ch.oddb.org should contain a link to the limiation in Sevikar HCT preparation
rspec ./spec/evidentia_spec.rb:128 # ch.oddb.org should contain a link to the price comparision in price public
rspec ./spec/evidentia_spec.rb:138 # ch.oddb.org should contain a link to the FI for the drug when in price comparison
rspec ./spec/evidentia_spec.rb:154 # ch.oddb.org should NOT contain a link to the expired fachinfo for Lamivudin-Zidovudin
rspec ./spec/evidentia_spec.rb:163 # ch.oddb.org should display a limitation link for Sevikar HCT
rspec ./spec/evidentia_spec.rb:177 # ch.oddb.org should display lamivudin with SO and SG in category (price comparision)
rspec ./spec/evidentia_spec.rb:184 # ch.oddb.org should list trademark first e.g. Duodopa
rspec ./spec/evidentia_spec.rb:222 # ch.oddb.org should display Cellcept before other
rspec ./spec/evidentia_spec.rb:230 # ch.oddb.org should list Levetiracetam Desitin with a link to the product overview
rspec ./spec/home_2_list_spec.rb:82 # ch.oddb.org admin in home_companies we should see all companies when logged in as admin
rspec ./spec/home_2_list_spec.rb:87 # ch.oddb.org admin in home_companies we should have the link active_companies if logged in as admin
rspec ./spec/interactions_spec.rb:247 # ch.oddb.org should show interactions having given iksnr,ean13,atc_code,iksnr
rspec ./spec/interactions_spec.rb:266 # ch.oddb.org should show interactions having given iksnrs
rspec ./spec/paypal_spec.rb:113 # ch.oddb.org should show the poweruser dialog with the top left logo
rspec ./spec/paypal_spec.rb:131 # ch.oddb.org should be checkout via paypal as poweruser for one day
rspec ./spec/preferences_spec.rb[1:1] # ch.oddb.org should save the color prefence as user 
rspec ./spec/preferences_spec.rb[1:2] # ch.oddb.org should save the color prefence as user ngiger@ywesee.com
rspec ./spec/preferences_spec.rb[1:3] # ch.oddb.org should save the color prefence as user info@desitin.ch
rspec ./spec/searchbar_spec.rb:271 # ch.oddb.org should show no drugs for Fortex via unwanted effects search
rspec ./spec/searchbar_spec.rb:325 # ch.oddb.org should set best_result when searching Rivoleve via search_type
rspec ./spec/smoketest_spec.rb:375 # ch.oddb.org desitin should download the example

Fixed two paypal errors. Adapted the interaction specs as two interaction are no longer considered harmful.

Pushed commits

Must remove some item on the home_user. Removed fipi_offer and plugin. Running all unit and watir tests.

Pushed commits

Running the watir tests I remarked that after changing a preference, the user does not get redirected to home. This must be fixed tomorrow. Also rerunning the watir tests, as they showed too many errors in the interactions, which passed, when run separately.

view · edit · sidebar · attach · print · history
Page last modified on November 28, 2017, at 05:20 PM