20160726-migrate-davaz-com-fix-unit-test-sandoz-xmlconv-bbmb-ch

<< 20160727-migrate-davaz-com-dojo-widgets | Index | 20160725-debug-request-encoding-sandoz-xmlconv-bbmb-ch >>

Summary

• Fix unit tests on sandoz.xmlconv.bbmb.ch
• Migrate davaz.com (javasrcipt)

Commits / Patches / Pull Requests, Scripts

• Remove unnecessary white space [commit, sandoz.xmlconv.bbmb.ch]
• Fix image markup [commit, sandoz.xmlconv.bbmb.ch]
• Prevent duplicated widgets by multiple clicks [commit, davaz.com]
• Fix admin art object form [commit, davaz.com]
• Fix toggle function for serie,tool and material [commit, davaz.com]
• Fix typo :'( [commit, davaz.com]
• Add canceling by re:click of new serie link[commit, davaz.com]

Index

• Fix Unit Tests on sandoz.xmlconv.bbmb.ch
• Migrate davaz.com widgets
  • Dojo Widgets
  • Prevent duplicated actions by double click
  • Fix NoMethodError for artobject
  • Fix toggle function for serie (tool and material)
• Fix Duplicated Ajax rack request

Fix Unit Tests on sandoz.xmlconv.bbmb.ch

Fixed tests.
Errors were caused by unnecessary white space.

Commit: Remove unnecessary white space

And, I've setuped travis-ci for my personal branch on remote repository.
Because we cannot change hook,setting on central repository.

https://travis-ci.org/grauwoelfchen/sandoz.xmlconv.bbmb.ch

Migrate davaz.com widgets

Dojo Widgets

Current progress is below. Today I would like to migrate EditWidget and some other widgets.

• [x] desk.js
• EditButtons.js
• EditWidget.js
• GuestbookWidget.js
• Input.js
• InputText.js
• InputTextarea.js
• [x] login.js (LoginWidget.js)
• [x] oneliner.js
• [x] rack.js
• [x] show.js
• [x] slide.js (SlideShow.js)
• [x] ticker.js
• [x] Tooltip.js

Prevent duplicated actions by double click

Currently, (in production also) some links and submit tags work for (duplicated) multiple action by dobule/triple clicks.
Then I've changed this to prevent by state in html attributes.

Commit:Prevent duplicated widgets by multiple clicks

Fix NoMethodError for artobject

Ajax fetching returns error.

/en/gallery/ajax_desk/artgroup_id/PAI/serie_id/ADC/artobject_id/567

NoMethodError undefined method `artobject_id' for nil:NilClass

error in SBSM::Session#http_headers: /en/gallery/ajax_desk/artgroup_id/PAI/serie_id/ADC/artobject_id/567
NoMethodError                                                                      
undefined method `artobject_id' for nil:NilClass                                   
/path/to/davaz.com/src/view/select.rb:11:in `init'                                 
/path/to/davaz.com/.bundle/gems/ruby/2.3.0/gems/htmlgrid-1.1.1/lib/htmlgrid/component.rb:139:in `initialize'
/path/to/davaz.com/.bundle/gems/ruby/2.3.0/gems/htmlgrid-1.1.1/lib/htmlgrid/namedcomponent.rb:34:in `initialize'
/path/to/davaz.com/.bundle/gems/ruby/2.3.0/gems/htmlgrid-1.1.1/lib/htmlgrid/composite.rb:114:in `new'
/path/to/davaz.com/.bundle/gems/ruby/2.3.0/gems/htmlgrid-1.1.1/lib/htmlgrid/composite.rb:114:in `block in component

Commit: Fix admin art object form

Fix toggle function for serie (tool and material)

If I click "Cancel" or re:click "Add New Serie" link, then Input Widget creation fails,
because previouse widget's id is registered into dojo registry.

Commits:
* Fix toggle function for serie,tool and material

• Add canceling by re:click of new serie link

Fix Duplicated Ajax rack request

When I access Drawings, and then select Desk widget, following ajax requests are send.

GET /en/gallery/ajax_rack/artgroup_id/DRA/serie_id/AAG/artobject_id/49  200 OK  39ms
GET /en/gallery/ajax_desk/artgroup_id/DRA/serie_id/AAG/artobject_id/49  200 OK  54ms

Desk depends existence of Rack widget.
Its handlings in sever side are almost same (duplicated).

Then I reduce these ajax request only once (in each, rack and desk).

continue tomorrow.