20110414-update-export_flag-methods-testcases-oddb_org-util-http_rb-meddata-session_rb-view-register_download_rb-migel-result_rb

<< | Index | >>

1. Update export_flag admin command
2. Update testcases

Goal/Estimate/Evaluation

• Testcases / 83% / 82.54%

Milestones

• Update testcases
  1. src/util/http.rb (coverage: 100%) 8:00
  2. ext/meddata/src/session.rb (coverage: 100%) 13:30
  3. src/view/user/register_download.rb (coverage: 100%) 15:30
  4. src/view/migel/result.rb (coverage: 100%)

Summary

• http://masay.ch/2011/04/14/update-export_flag-methods-testcases-oddb_org-util-http_rb-meddata-session_rb-view-register_download_rb-migel-result_rb/

Commits

• We forgot to Update App and only updated Prevalance (Memory) with the commit from yesterday, so we added two methods to the App Class as well. Now running the command from bin/admin will result in updating the Memory and the Database. (oddb.org)
• Updated testcases, test_util/http.rb, ext/meddata/test/test_session.rb, test_view/user/register_download.rb, migel/result.rb (oddb.org)

Update export_flag admin command

Problem

• After the rebooting of oddbd, the set of export_flag was gone
• This means the updates are not saved in the database, but only in the cache (memory)

Solution

• Add a method to call 'update' method in ODDB::App class, not ODDB::OddbPrevalence class
  • Yesterday, we added the methods in OddbPrevalence class

Commit

• We forgot to Update App and only updated Prevalance (Memory) with the commit from yesterday, so we added two methods to the App Class as well. Now running the command from bin/admin will result in updating the Memory and the Database. (oddb.org)

Memo

• Points:
  1. OddbPrevalence class manages the objects in the cache and App class manages the data in the database through @system instance
  2. @system instance is created in the initialize method of App class through ODBA.cache.fetched_name method

Confirmation

1. Execute update_swissmedic with the latest Packungen and Präparatieste xls files online
2. Confirm that all the export_flags become 'true' and the search result shows nothing
3. Execute set_all_export_flag_registratino(false) and set_all_export_flag_sequence(false) from bin/admin
4. Execute update_swissmedic again with the latest Packungen in April and the Präparatiste xls file in March that has N and O columns
5. Confirm the searching result