20111026-change-admin-link-format-oddb_org

<< | Index | >>

1. Replace Narcotics List Link
2. Replace Admin/Address link suspend
3. Replace Admin/Galenik link
4. Replace Admin/CommercialForm link
5. Replace Admin/Indication link
6. Replace FeedBack link in drug search view

Goal/Estimate/Evaluation

• Replace pointer link in Admin / 70% / 80%

Commit

• Replaced Narcotic link format without pointer (oddb.org)
• Replaced Package link format without pointer in Narcotic view (oddb.org)
• Replace odba_id to oid to create a link to Narcotic view (oddb.org)
• Replaced Galenic group and form links without pointer (oddb.org)
• Replaced Commercial Form link in Admin view without pointer (oddb.org)
• Replaced Indication link wihtout pointer in Admin view (oddb.org)
• Replaced Indication link in Admin Indication list view (oddb.org)
• Replaced FeedBack link without pointer in drug search view (oddb.org)

Replace Narcotics List Link

Replace link

• old: http://oddb.masa.org/de/gcc/resolve/pointer/%3A%21narcotic%2C813251.
• new: http://oddb.masa.org/de/gcc/narcotic/oid/813251

Note

• Package 1--->* Narcotic
• Narcotic 1--->* Substance
• Substance 1--->1 Narcotic

Access

• example1: http://oddb.masa.org/de/gcc/narcotic/oid/813251
• example2: http://oddb.masa.org/de/gcc/narcotic/oid/813270
• example3: http://oddb.masa.org/de/gcc/narcotic/oid/111111
• Narcotics List: http://oddb.masa.org/de/gcc/narcotics/range/s

Commit

• Replaced Narcotic link format without pointer (oddb.org)
• Replaced Package link format without pointer in Narcotic view (oddb.org)
• Replace odba_id to oid to create a link to Narcotic view (oddb.org)

Replace Admin/Address link

Link

• old: http://oddb.masa.org/de/gcc/resolve/pointer/%3A%21address_suggestion%2C780364.
• new: http://oddb.masa.org/de/gcc/address_suggestion/oid/780364

Note

• There are warnings

/home/masa/ywesee/oddb.org/src/view/address.rb:67: warning: Object#type is deprecated; use Object#class
/home/masa/ywesee/oddb.org/src/view/address.rb:122: warning: Object#type is deprecated; use Object#class

• 'suggest_address' event is already defined

Access

• List http://oddb.masa.org/de/gcc/addresses/

Note

• Pointer instance is used to resolve the parent instance as follows

 module ODDB
   module State
    module Admin
 class AddressSuggestion < Global
   def init
    if(pointer = @model.address_pointer)
      addr = pointer.resolve(@session)
      if(addr.nil?)
        addr = Address2.new
        addr.pointer = pointer
      end
      @active_address = AddressWrapper.new(addr)
      parent = pointer.parent.resolve(@session)
      select_zone(parent)
      @active_address.email_suggestion = parent.email
    end
    super
   end

• This parent problem should be resolved otherwise it is impossible to replace all the link format wihtout Pointer class
• Sometimes it can be replaced by using XXXObserver module method, but in this case there is no Observer module included in ODDB::Address2 class

suspend

Replace Admin/Galenik link

Link

• old: http://oddb.masa.org/de/gcc/resolve/pointer/%3A%21galenic_group%2C5.
• new: http://oddb.masa.org/de/gcc/galenic_group/oid/5

Note (IMPORTANT)

• oid and odba_id are usually same but not totally same, sometimes different
• It does not make sense to use two similar types of INDEX number in a system

ch.oddb> galenic_group('890150').oid
-> 890150
ch.oddb> galenic_group('890150').odba_id
-> 890150
ch.oddb> galenic_group('5').oid
-> 5
ch.oddb> galenic_group('5').odba_id
-> 3790

Update

• src/state/global.rb

      def galenic_group
        if oid = @session.user_input(:oid) and model = @session.app.galenic_group(oid)
          if @session.allowed?('edit', 'org.oddb.model.!galenic_group.*')
            ODDB::State::Admin::GalenicGroup.new(@session, model)
          else
            ODDB::State::Admin::TransparentLogin.new(@session, model)
          end
        end
      end

• src/view/admin/galenicgroups.rb

  def oid(model, session)
    link = View::PointerLink.new(:oid, model, session)
    link.href = @lookandfeel._event_url(:galenic_group, {:oid => model.oid})
    link
  end
  def description(model, session)
    link = View::PointerLink.new(:description, model, session)
    link.href = @lookandfeel._event_url(:galenic_group, {:oid => model.oid})
    link
  end

Access

• new: http://oddb.masa.org/de/gcc/galenic_group/oid/5
• list: http://oddb.masa.org/de/gcc/galenic_groups/

Galenic Form link

• old: http://oddb.masa.org/de/gcc/resolve/pointer/%3A%21galenic_group%2C5%21galenic_form%2C103.
• new: http://oddb.masa.org/de/gcc/galenic_form/goid/5/foid/103

Update

• src/state/global.rb

      def galenic_group
        if oid = @session.user_input(:oid) and model = @session.app.galenic_group(oid)
          if @session.allowed?('edit', 'org.oddb.model.!galenic_group.*')
            ODDB::State::Admin::GalenicGroup.new(@session, model)
          else
            ODDB::State::Admin::TransparentLogin.new(@session, model)
          end
        end
      end
      def galenic_form
        if group_oid = @session.user_input(:goid) and group = @session.app.galenic_group(group_oid) and model = group.galenic_form(@session.user_input(:foid))
          if @session.allowed?('edit', 'org.oddb.model.!galenic_group.*')
            ODDB::State::Admin::GalenicForm.new(@session, model)
          else
            ODDB::State::Admin::TransparentLogin.new(@session, model)
          end
        end
      end

• src/util/validator.rb

    EVENTS = [
      :galenic_form,
      :galenic_group,

    STRINGS = [
      :foid,
      :goid,

• src/view/admin/galenicgroup.rb

  def oid(model, session)
    link = View::PointerLink.new(:oid, model, session)
    link.href = @lookandfeel._event_url(:galenic_form, [:goid, model.galenic_group.oid, :foid, model.oid])
    link
  end
  def description(model, session)
    link = View::PointerLink.new(:description, model, session)
    link.href = @lookandfeel._event_url(:galenic_form, [:goid, model.galenic_group.oid, :foid, model.oid])
    link
  end

• src/view/admin/galenicgroups.rb

  def oid(model, session)
    link = View::PointerLink.new(:oid, model, session)
    link.href = @lookandfeel._event_url(:galenic_group, {:oid => model.oid})
    link
  end
  def description(model, session)
    link = View::PointerLink.new(:description, model, session)
    link.href = @lookandfeel._event_url(:galenic_group, {:oid => model.oid})
    link
  end

Access

• new: http://oddb.masa.org/de/gcc/galenic_form/goid/5/foid/103
• list: http://oddb.masa.org/de/gcc/galenic_group/oid/5

Commit

• Replaced Galenic group and form links without pointer (oddb.org)

Replace Admin/CommercialForm link

Link

• old: http://oddb.masa.org/de/gcc/resolve/pointer/%3A%21commercial_form%2C1067477.
• new: http://oddb.masa.org/de/gcc/commercial_form/oid/1067477

Update

• src/state/global.rb

      def commercial_form
        if oid = @session.user_input(:oid) and model = @session.app.commercial_form(oid)
          ODDB::State::Admin::TransparentLogin.new(@session, model)
        end
      end

• src/state/admin/root.rb

  def commercial_form
    if oid = @session.user_input(:oid) and model = @session.app.commercial_form(oid)
      ODDB::State::Admin::CommercialForm.new(@session, model)
    end
  end

Access

• new: http://oddb.masa.org/de/gcc/commercial_form/oid/1067477
• list: http://oddb.masa.org/de/gcc/commercial_forms/

Commit

• Replaced Commercial Form link in Admin view without pointer (oddb.org)

Replace Admin/Indication link

Link

• old: http://oddb.masa.org/de/gcc/resolve/pointer/%3A%21indication%2C10656271.
• new: http://oddb.masa.org/de/gcc/indication/oid/10656271

Update

• src/state/global.rb

      def indication
        if oid = @session.user_input(:oid) and model = @session.app.indication(oid)
          ODDB::State::Admin::TransparentLogin.new(@session, model)
        end
      end

• src/util/validator.rb

    EVENTS = [
                       :indication,

• src/state/admin/root.rb

  def indication
    if oid = @session.user_input(:oid) and model = @session.app.indication(oid)
      State::Admin::Indication.new(@session, model)
    end
  end

• src/view/admin/indications.rb

  def description(model, session)
    link = View::PointerLink.new(:description, model, session)
    link.href = @lookandfeel._event_url(:indication, {:oid => model.oid})
    link
  end

Access

• new: http://oddb.masa.org/de/gcc/indication/oid/10656271
• list: http://oddb.masa.org/de/gcc/indications/

Commit

• Replaced Indication link wihtout pointer in Admin view (oddb.org)
• Replaced Indication link in Admin Indication list view (oddb.org)

Replace FeedBack link in drug search view

Link

• old: http://oddb.masa.org/de/gcc/feedbacks/pointer/%3A%21registration%2C41810%21sequence%2C02%21package%2C069.
• new: http://oddb.masa.org/de/gcc/feedbacks/reg/418102/seq/02/pack/069

Commit

• Replaced FeedBack link without pointer in drug search view (oddb.org)