Index>

20150121-oddb2xml

Summary

• create reseller_pub price in oddb2xm
• remove feedback in detail view of a package
• login for migel

Commits

• https://github.com/ngiger/oddb.org/commit/a6c0a48eda0a347e1358ab3e7a15a75915ac30d9 Disable feedback for evidentia LnF in package view
• https://github.com/ngiger/oddb.org/commit/484506728189eebee58197473df9b368cbee8f06 Fix explain narcotics and link
• https://github.com/ngiger/oddb.org/commit/e5a7e255dc0b793f33f60981ddd4621363d5bac3 Fix disable narcotic link in resultlist
• https://github.com/ngiger/oddb2xml/commit/d6dfdec4f5914c6dc3f94d785d2c0b5a4cc5a32c Bumped version to 1.9.3 and fixed meaning of -I x

Index

• create reseller_pub price in oddb2xml
• remove feedback in detail view of a package
• login for migel

Keep in Mind for work to do

• Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
• I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
• The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
• creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
• Display 10 recalls not only those from this month
• Import via data/medreg_companies.yaml

---

login for migel

Currently we have the following behaviour:

• login
• going to home shows the login name
• Click on Migel
• login lost (Display Login at bottom)

This must be fixed, as going to Migel should not change the login status. Created a watir test to check this behaviour.

What is bizarr, that after executing a Migel search, e.g. Krücke, I am logged in again. When logged in as desitin I loose the login if I go to one of the zones Hospital, Doctor, Pharmacies and Migel.

remove feedback in detail view of a package

I am surprised that @lookandfeel.enabled?(:feedback) returns true in src/view/drugs/package.rb

Fixed with commit Disable feedback for evidentia LnF in package view where I also removed some unused explanations. Pushed changes. Pulled them on thinpower and restarted the oddbd service.

Running spec tests.

Fixed link for narcotices and moved it to the lookandfeelbase. See commit Fix explain narcotics and link

Another commit is Fix disable narcotic link in resultlist. Pushed and activated on thinpower.

create reseller_pub price in oddb2xml

Yesterday we discovered that we had not nailed down the specifications for oddb2xml correctly.

I proposed therefore to implement the -I option like the following

    -I x, --increment=x  create additional field resellerpub as price_extfactory 
                         incremented by x percent (rounded to the next 0.05 francs).
                         Forces -f dat -p zurrose.

Locally adapted code an unit tests. The field PRPU in the generated zurrose_transfer.dat must contain also the newly calculated price. Made all spec-tests pass again.

Running rake test and waiting for its outcome before pushing commit.

Compared a few files manually between the output of 1.8.9 and 1.9.3. Looks good. In 1.9.3/oddb2xml__f_dat___append/oddb_with_migel.dat we have many more prices than in 1.8.9.

Pushed commit Bumped version to 1.9.3 and fixed meaning of -I x