Index>
20150720-update-compositions
Summary
- Adapt oddb.org to new fields for compositions
- Must align Packungbestandteile everyghing align to the left link
- Avoid '0' for doses
Commits
Index
- Keep in Mind for work to do
-
- Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
- I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
- The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
- creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
- Import via data/medreg_companies.yaml
- Fix problem with radioactivatum 99m-technetio when parsing Wirkstoffe
- Fix galenic_forms when parsing swissmedic.xlsx
- Cleanup generic_type. Replace it everywhere by sl_generic_type and adapt code accordingly.
- Get updated ATC-codes from EPha for oddb.org, too.
- Display new fields CORRESP for compositions in oddb.org.
- Use refdatabase for oddb.org, too.
- Fix running rspec for new packungen.xlsx in oddb2xml
Avoid '0' for doses
We must avoid outputting a '0' when displaying Hilfstoffe like E 216 without an dosage information. But it would probably even better to avoid import such doses at all.
Also when looking at http://oddb-ci2.dyndns.org/de/gcc/show/reg/00417/seq/01 I see the text no excipiens.
Fixed with commits
Adapt oddb.org to new fields for compositions
Cleaning up changes. Moving many debug_msg into trace_msg (not emitting anything by default). Fixing E-Mail result. Don't know howto avoid error Could not create: :!00278,sequence,01!composition., reason: :!00278,sequence,01!composition. -> OddbPrevalence::registration(00278,sequence,01) returned nil when running test/test_plugin/swissmedic.rb. This leads to an unexpected failure
Pushed commits to master branch, ending with Fix css. Remove debug output
Have problems adding a valid corresp to the IKSNR 00488. Debugging with pry. Did see, that 448 Hepatec has a corresp in its source text, but does not produce a corresp field after parsing. IKSNR 00417 or 00585 look better. Has no corresp. in its source, but produces a corresp field
.
Must align Packungbestandteile everything align to the left link
This can be done by changing (via oddb*.css) in the styles div#composition-list div and div#composition-list div.galenic-form the element padding from 4px 8px 4px 0px to 4px 0px 4px 0px. Before pushing, waiting to see whether zeno is okay with it.
Fixed with commit Align composition-list to the left in all *.ccs.