Index>
20150923-repair-atc-code
Summary
- Show price history of PP again
- Functionality of link "Präparate" in price comparision must move to "PP/Vergleich"
- Add new method origin for atc_codes to be able to distinguis between code from who, swissmedic, refdata or unknown
- Fix problem with kaletra where two different ATC-codes (J05AE06 and J05AR10) are found
Commits
Index
- Keep in Mind for work to do
-
- Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
- I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
- The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
- creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
- Import via data/medreg_companies.yaml
- Fix problem with radioactivatum 99m-technetio when parsing Wirkstoffe
- Fix galenic_forms when parsing swissmedic.xlsx
- Cleanup generic_type. Replace it everywhere by sl_generic_type and adapt code accordingly.
- Get updated ATC-codes from EPha for oddb.org, too.
- Use refdatabase for oddb.org, too.
- Check whether we should revert the part which touche src/plugin/text_info.rb of commit 17af82ba4d76a5838683411b260de265531f9e74. We should improve test/stub/oddbapp.rb to work similar for update/pointer as the real oddbapp. In this case we would have a good Stub for plugins. May we need a different stub when working with plugins (which create/modify/destroy ODDB-Objects), when in most other cases a very simple stub is sufficient.
- Create a history of FI changes and add a nice diff (colored) to compare any two versions. Look at gems like diffy or differ
- Ofev (IKSNR 65330) has a not yet WHO-Approved ATC-Code L01XE31. The job atc_less should add the new ATC-Code with an empty name and flag it in its report for human intervention (e.g. extracting the substance name from the FI)
- When a logged in admin user changes an atc_code of a product, the corresponding atc_class must update its sequences, too.
- Get ATC-Code from FI and compare it to the XML and Packungen.xlsx
Fix problem with kaletra where two different ATC-codes (J05AE06 and J05AR10) are found
Add new method origin for atc_codes to be able to distinguis between code from who, swissmedic, refdata or unknown. Correct the plugin/who to set the origin mode for all atc_classes imported to :whocc.
Add a new procedure in model/atc_class.rb which removes sequences which (no longer) belong to the atc_code. There is large number of them. Investigating the problem, why a second run still finds more occurrences. It takes 7 runs till we don't find any occurrences. See Attach:repair_atc_1_log.txt
Looking for a way to integrate this functionality into jobs/import_who. Dropping and reloading the database to run the modified who job.
Done with commit Add origin and repair_needed? to atc_class
Kaletra still shows up with two atc_codes J05AR10 and J05AE06 because we consider old sequences. To ignore non active sequences, I try to fix that in src/model/search_result.rb, where the method sequences is changed to @atc.sequences.find_all{|sequence| sequence.active?}
It was even easy to add a unit test for it. Pushed commit Return only active sequences in search_result
Show price history of PP again
My commits of yesterday made the link to the price history go away. Must add a watir-test for this functionality and fix the problem.
Fixed with commit Fix price-history for price-public
Functionality of link "Präparate" in price comparision must move to "PP/Vergleich"
Also the link of the items under "Präparate" must point to the Fachinfo.
Moved code for link_trade_name_to_fachinfo and link_pubprice_to_price_comparison from resultlist.rb -> dataformat.rb. This made the changes work automatically for the both views. Improved test_view/dataformat.rb with checks for most of the changes. Also updated the smoke_test_spec and evidentia_spec.
Fixed the problem with Always link to FI/Price-comparision when enabled
My commit had an error, when no valid price is found and "k.A" (aka Keine Angaben) is returned. Fixed with commit Catch k.A for price-public (evidentia)