view · edit · sidebar · attach · print · history

< Niklaus.20160201-oddb2xml-hangs | Index | Niklaus.20160126-sort-order-duodopa >>

20160127-enable-bestresult

Summary

  • We should enable jumping to the best result for price and price/substance search

Commits

Index

Keep in Mind for work to do
  • Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
  • I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
  • The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
  • creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
  • Import via data/medreg_companies.yaml
  • Fix problem with radioactivatum 99m-technetio when parsing Wirkstoffe
  • Fix galenic_forms when parsing swissmedic.xlsx
  • Cleanup generic_type. Replace it everywhere by sl_generic_type and adapt code accordingly.
  • Get updated ATC-codes from EPha for oddb.org, too.
  • Use refdatabase for oddb.org, too.
  • Check whether we should revert the part which touche src/plugin/text_info.rb of commit 17af82ba4d76a5838683411b260de265531f9e74. We should improve test/stub/oddbapp.rb to work similar for update/pointer as the real oddbapp. In this case we would have a good Stub for plugins. May we need a different stub when working with plugins (which create/modify/destroy ODDB-Objects), when in most other cases a very simple stub is sufficient.
  • When a logged in admin user changes an atc_code of a product, the corresponding atc_class must update its sequences, too.
  • Order of entering search type and value should not matter. Both should show long URL with search
  • Remove parser for minifi (but keep the minifi)

We should enable jumping to the best result for price and price/substance search

Debugging JavaScript and checking whether we should use the third parameter of event_url(event=direct_event, args={}, anchor=nil). No using the third argument does no work. Creates URL like http://oddb-ci2.dyndns.org/de/gcc/search/zone/drugs/search_query/#best_result

After debugging for many hours I finally found a quite a simple solution by patching the onChange in search_type of SearchBarMethods.

Debugging took so much time, because our combination of Ruby and JavaScript produced (again) syntax error, when I did no expect them. Problematic areas are

  • In javascript snippt a form.#{value}, where value (= Ruby variable). This can only be seen when looking at the HTML-code.
  • The CheckBox to enable "Pause on Caught Exception" (eg. Syntax errors) is only visible in the "Sources" tab and the Button "Pause on exceptions"

Running all watir tests to ensure that I didn't introduce any unwelcomed side effects.

Pushed commit Fix searching when using search_type

view · edit · sidebar · attach · print · history
Page last modified on January 27, 2016, at 06:08 PM