view · edit · sidebar · attach · print · history

< Niklaus.20160215-fi-parser-use-refdata-names | Index | Niklaus.20160203-fix-bsv-followers >>

20160210-undefined-activeSequences

Summary

  • Adapt FI-parser to use refdata names for packages
  • Undefined method active_sequences

Commits

Index

Keep in Mind for work to do
  • Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
  • I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
  • The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
  • creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
  • Import via data/medreg_companies.yaml
  • Fix problem with radioactivatum 99m-technetio when parsing Wirkstoffe
  • Fix galenic_forms when parsing swissmedic.xlsx
  • Cleanup generic_type. Replace it everywhere by sl_generic_type and adapt code accordingly.
  • Get updated ATC-codes from EPha for oddb.org, too.
  • Use refdatabase for oddb.org, too.
  • Check whether we should revert the part which touche src/plugin/text_info.rb of commit 17af82ba4d76a5838683411b260de265531f9e74. We should improve test/stub/oddbapp.rb to work similar for update/pointer as the real oddbapp. In this case we would have a good Stub for plugins. May we need a different stub when working with plugins (which create/modify/destroy ODDB-Objects), when in most other cases a very simple stub is sufficient.
  • When a logged in admin user changes an atc_code of a product, the corresponding atc_class must update its sequences, too.
  • Order of entering search type and value should not matter. Both should show long URL with search
  • Remove parser for minifi (but keep the minifi)

Adapt FI-parser to use refdata names for packages

Adding a unit test for the report method of plugin/text_info.rb made appear a long standing bug appear, where two variables fi_without_atc_code and fi_atc_code_missmatch were initialized to a wrong value.

Fixed by changing src/plugin/text_info.rb

      @duplicate_entries = []
      @fi_without_atc_code = [],
      @fi_atc_code_missmatch = [],
      @target_keys = Util::COLUMNS_JULY_2015

to

      @duplicate_entries = []
      @fi_without_atc_code = []
      @fi_atc_code_missmatch = []
      @target_keys = Util::COLUMNS_JULY_2015

Splitting the AipsDownload take about 25 minutes via the plugin/text_info.rb which is much slower than the standalone variant, which took only 4 seconds. Why? Found the culprit. Had added an xmllint --format for each produced file. Delegating this to separate threads.

Also I did the following errors

2016-02-10 10:21:00 +0100: job is done. now postprocess works ...
rss/fachinfo 68: rescue #<NoMethodError: undefined method `collect' for #<ODDB::Address2:0x000000426c14b0>> for rss/fachinfo 68: #<ODBA::Stub:717908040#34442116 @odba_class= @odba_container=711737160#21>: backtrace is: 
  /usr/local/lib/ruby/gems/1.9.1/gems/odba-1.1.0/lib/odba/stub.rb:112:in `method_missing'
  /var/www/oddb.org/src/model/registration_observer.rb:36:in `iksnrs'
  /usr/local/lib/ruby/gems/1.9.1/gems/odba-1.1.0/lib/odba/stub.rb:112:in `method_missing'
  /var/www/oddb.org/src/view/rss/fachinfo.rb:38:in `item_to_html'
  /var/www/oddb.org/src/view/rss/fachinfo.rb:89:in `block (2 levels) in to_html'
  /var/www/oddb.org/src/view/rss/fachinfo.rb:83:in `each'

Adapting the code to support italian, too.

Creating a file problematic_fi_pi.lst containing all necessary info to classify duplicated FI/PIs.

Adapting src/model/package.rb to allow a patinfo inside the package, while fetching it from the sequence if absent.

Using etc/barcode_to_text_info.yml to allow setting the name to use from the AipsDownload.xml. Testing it with the line 7680437880197_pi_de: "Tramal® Tropfen, Lösung zum Einnehmen". This works, but I must adapt my code to create a Patinfo-Object not a PatinfoDocument.

Saved stated in Attach:patch_rework_t8.txt

Undefined method active_sequences

Must avoid error in /var/www/oddb.org/log/oddb/debug/2016/02.log

NoMethodError: undefined method `active_sequences' for
:ODDB::Substance when updating index 'substance_index_sequence' with a
ODDB::Substance
["/var/www/oddb.org/src/util/language.rb:53:in `method_missing'",
"(eval):2:in `block in proc_instance_target'",
"/usr/local/lib/ruby/gems/1.9.1/gems/odba-1.1.0/lib/odba/index.rb:249:in
`call'", "/usr/local/lib/ruby/gems/1.9.1/gems/odba-1.1.0/lib/odba/index.rb:249:in
`update_origin'"]
view · edit · sidebar · attach · print · history
Page last modified on February 10, 2016, at 06:13 PM