view · edit · sidebar · attach · print · history

< Niklaus.20160316-oddb2xml-prodno | Index | Niklaus.20160314-wrong-pi-dokus >>

20160315-swissmedic-packages

Summary

  • Swissmedic import does not create correctly missing packages

Commits

Index

Keep in Mind for work to do
  • Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
  • I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
  • The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
  • creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
  • Import via data/medreg_companies.yaml
  • Fix problem with radioactivatum 99m-technetio when parsing Wirkstoffe
  • Fix galenic_forms when parsing swissmedic.xlsx
  • Cleanup generic_type. Replace it everywhere by sl_generic_type and adapt code accordingly.
  • Get updated ATC-codes from EPha for oddb.org, too.
  • Use refdatabase for oddb.org, too.
  • Check whether we should revert the part which touche src/plugin/text_info.rb of commit 17af82ba4d76a5838683411b260de265531f9e74. We should improve test/stub/oddbapp.rb to work similar for update/pointer as the real oddbapp. In this case we would have a good Stub for plugins. May we need a different stub when working with plugins (which create/modify/destroy ODDB-Objects), when in most other cases a very simple stub is sufficient.
  • When a logged in admin user changes an atc_code of a product, the corresponding atc_class must update its sequences, too.
  • Order of entering search type and value should not matter. Both should show long URL with search
  • Remove parser for minifi (but keep the minifi)
  • BSV-Plugin does not send mail. Is it sending two mails at once?

Swissmedic import does not create correctly missing packages

The swissmedic import does not re-created missing packages. Debugging why I see lines like src/plugin/swissmedic.rb:969:in `update_package': update_package 00666/01/001 {}, but no package is created for it after the run.

Remarked that the export_flags are no longer respected. Fixed reading Präparateliste. Added a debug line to tell how many export sequences and registrations were found.

Also fixed an error in delete, where the packnr always comes from the row[2].

Also pondering why we loop 3 times to set all export_flags correctly via

        set_all_export_flag_false
        update_export_sequences @export_sequences
        update_export_registrations @export_registrations

instead of updating them all in one loop, which would be far more efficient (and save quite some time as each loop takes about 10 minutes).

When looking at 33105 Duspatalin, Dragées (http://oddb-ci2.dyndns.org/de/gcc/drug/reg/33105) which has the export_flag I see that the valid_until is set to 22.12.2011, whereas in Präparateliste it is 22.11.16 and cannot be found in Packungen.xlsx.

Fixed the error that verifying the packages used the old latest_file and not the currently downloaded file.

view · edit · sidebar · attach · print · history
Page last modified on March 15, 2016, at 12:19 PM