view · edit · sidebar · attach · print · history

< Niklaus.20160404-import-bsv-problem | Index | Niklaus.20160323-textinfo-pi >>

20160329-fix-nil-problem-in-import-daily

Summary

  • fix nil problem in import_daily

Commits

Index

Keep in Mind for work to do
  • Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
  • I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
  • The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
  • creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
  • Import via data/medreg_companies.yaml
  • Fix problem with radioactivatum 99m-technetio when parsing Wirkstoffe
  • Fix galenic_forms when parsing swissmedic.xlsx
  • Cleanup generic_type. Replace it everywhere by sl_generic_type and adapt code accordingly.
  • Get updated ATC-codes from EPha for oddb.org, too.
  • Use refdatabase for oddb.org, too.
  • Check whether we should revert the part which touche src/plugin/text_info.rb of commit 17af82ba4d76a5838683411b260de265531f9e74. We should improve test/stub/oddbapp.rb to work similar for update/pointer as the real oddbapp. In this case we would have a good Stub for plugins. May we need a different stub when working with plugins (which create/modify/destroy ODDB-Objects), when in most other cases a very simple stub is sufficient.
  • When a logged in admin user changes an atc_code of a product, the corresponding atc_class must update its sequences, too.
  • Order of entering search type and value should not matter. Both should show long URL with search
  • Remove parser for minifi (but keep the minifi)
  • BSV-Plugin does not send mail. Is it sending two mails at once?
  • remove obsolete pdf_patinfo in model, admin/views

fix nil problem in import_daily

Got the following error mail

Plugin: ODDB::TextInfoPlugin
Error: NoMethodError
Message: undefined method `barcode' for ["47429", "fi", "de"]:Array
Backtrace:
/var/www/oddb.org/src/plugin/text_info.rb:1318:in `block (3 levels) in report_problematic_names'
/var/www/oddb.org/src/plugin/text_info.rb:1317:in `each'
/var/www/oddb.org/src/plugin/text_info.rb:1317:in `block (2 levels) in report_problematic_names'
/var/www/oddb.org/src/plugin/text_info.rb:1316:in `each'
/var/www/oddb.org/src/plugin/text_info.rb:1316:in `block in report_problematic_names'
/var/www/oddb.org/src/plugin/text_info.rb:1314:in `open'
/var/www/oddb.org/src/plugin/text_info.rb:1314:in `report_problematic_names'
/var/www/oddb.org/src/plugin/text_info.rb:1390:in `parse_aips_download'
/var/www/oddb.org/src/plugin/text_info.rb:1435:in `import_swissmedicinfo'
/var/www/oddb.org/src/util/updater.rb:560:in `block in update_notify_simple'
/var/www/oddb.org/src/util/updater.rb:536:in `call'
/var/www/oddb.org/src/util/updater.rb:536:in `wrap_update'
/var/www/oddb.org/src/util/updater.rb:554:in `update_notify_simple'
/var/www/oddb.org/src/util/updater.rb:333:in `update_textinfo_swissmedicinfo'
/var/www/oddb.org/src/util/updater.rb:200:in `run'
jobs/import_daily:13:in `block in <module:Util>'
/var/www/oddb.org/src/util/job.rb:40:in `call'
/var/www/oddb.org/src/util/job.rb:40:in `run'
jobs/import_daily:12:in `<module:Util>'
jobs/import_daily:11:in `<module:ODDB>'
jobs/import_daily:10:in `<main>'

Fixed with commit Fix report_problematic_names

Made report_problematic_names less verbose with commit Minimize report_problematic_names

view · edit · sidebar · attach · print · history
Page last modified on March 29, 2016, at 10:21 AM