view · edit · sidebar · attach · print · history

< Niklaus.20161107-steinwies-rack-call | Index | Niklaus.20161101-steinwies-rack-call >>

20161102-steinwies-rack-call

Summary

Commits

Index

Make Steinwies.ch work with rack based SBSM

Reverting (by hand) the patch which removed the CGI.initialize_without_offline_prompt method, as it lead to problems that when rendering page in the to_html procedure the method html in the passed CGI-element.

Also added @drb_uri in SimpleSBSM. But I think it must be moved in a later cleanup to the SBSM::DRbServer class. Now running rake test fails, because the trans_handler does not work as expected. Also missing is the integration of test/test_application, as it does not start the DRB server correctly.

Re-Added CGI.initialize_without_offline_prompt, needed for html method in CGI

Starting the DrbServer in the setup method fixed test/test_application. Pushed commit Fixed test/test_application.rb

Now must fix the transhandler. Problem is that Rack::Request has no uri accessor field as SBSM::Request has. Checking whether we use uri in oddb.org and steinwies.ch, too. Yes. In both cases we find in the transhandler, statements request.uri = HANDLER_URI (from oddb.org/src/util/trans_handler.rb). Trying to monkey path the Rack::Request class.

Removing unneeded Stub Classes for notes, server and SBSM::Request from test_transhandler.rb. Fixed the translate_uri methods and tests.

Pushed the following commits

But the state is not yet handled correctly for steinwies.ch. Must improve the unit tests for states in sbsm.

Working on the tests I as able to make the states work on steinwies.ch. But my simple_sbsm.rb does still not yet display an /about path. But after submitting the Form I still return to the home page. Looking at the generated debug-output to fix my simple_sbsm app for the unit tests. After adding a common GLOBAL_STATE for home, about and feedback, tests for visiting the different paths work now. Pushed commit Added unit test to visit several pages

Work on the Steinwies unit tests. Most of them pass with commit 32 of 35 unit tests work again About 2 of them do not work, as we do not handle correctly jpg/css files. Adding a unit test for these too. This was easy. Pushed commit Fixed handling CSS files

Now adding a unit test for handling post requests.

Fixed a problem with umlauts (UTF-8) with commit Cleanup. Added UTF-8 HTML header. Added & skipped unit test for feedback

Cleanup steinwies unit test. Skipping some, to make it pass under travis-CI. See Skip some unit tests

Preserving and accessing the session info is still a problem. Also test coverage for some important parts is missing, e.g. lookandfeel, viral_states, state and session. Also no tests exist for user login/logout.

Will continue next week.

view · edit · sidebar · attach · print · history
Page last modified on November 02, 2016, at 10:08 PM