view · edit · sidebar · attach · print · history






Make running under Rack

Trying to solve the two remaining bugs.

  1. Test login, then logout fails
  2. Running all tests produces more error, compared to running tests from a single file

For the first problem, I am collecting the HttpFox from a login/logout on It show for the logout/fragment

00:01:04.969	1.066	519	0	GET	303	Redirect (cached)
(Request-Zeile)	GET /en/admin/logout/fragment/ HTTP/1.1
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0
Accept	text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Accept-Language	de-CH,en-US;q=0.7,en;q=0.3
Accept-Encoding	gzip, deflate
Cookie; _session_id=1e4a2ec6c247b4cab8058e8e172c0637
00:01:06.158	0.424	513	(37311)	GET	(Cache)	text/html

Conclusion: A response with 303 Redirect is not yet handled correctly. Why? Was quite easy to fix, once you discovered that the http_headers were not read from the proxy. Must add a test case for this in sbsm, too.

Done with commit Fix handling http_headers, e.g. 303 for redirects

Test coverage for sbsm is now better, but we still miss many methods, and some of them are probably not used. Maybe we should get rid of them later once all of our apps are running with rack.

Looking at the tests in which fail when running individual these are

  • TestMovies#test_login_then_logout
  • TestDrawings#test_admin_drawings_removing_serie_failure [test/feature/drawings_test.rb:79
  • TestDrawings#test_admin_drawings_removing_serie_success [test/feature/drawings_test.rb:111
  • TestMovies#test_admin_movies_update_description_text_by_wysiwyg_editor
  • TestMovies#test_movies_pagination [test/feature/movies_test.rb:61
  • TestMovies#test_movies_show_a_thumbnail_of_its_movie [test/feature/movies_test.rb:48
  • TestShop#test_checkout_with_error [test/feature/shop_test.rb:42
  • TestShop#test_checkout_fails_with_validation_error [test/feature/shop_test.rb:132

Pushed commit Improved login/logout test.

Working on the drawing_test I discovered that the tests are not robust and must wait sometimes to let the javascripts run their task. Finished.

Working on the movies_test. Here the update of the title did not work, as we cannot save the text in the stubbed db_manager.

Marked 4 tests as skipped as in one case our db manager-stub does not save updated values and in the other cases these are real (but minor) errors also present on

Running rake test to see, whether we have no failure or not. Looks good now. Adding simplecov to see the coverage. I am also interested in the coverage of sbsm.

Done with adding the following lines in test/test_helper.rb

SimpleCov.start do
  filters.clear # This will remove the :root_filter and :bundler_filter that come via simplecov's defaults
  add_filter "/test/"
  add_filter "/gems/"
  add_filter do |src|
    !(src.filename =~ /^#{SimpleCov.root}/) unless src.filename =~ /sbsm/
  add_group "sbsm", "sbsm"
  add_group "davaz", ""
  add_group "Long files" do |src_file|
    src_file.lines.count > 100

Moved this code into a separate file and avoided a fake 100% by excluding rake. Coverage of davaz is good except for partials.

Pushed commits for sbsm 1.3.1 Added debug statement about unused code and Bumped version to 1.3.3

Pushed changes for Improved watir tests. Including simplecov and Updated Gemfile/Rakefile. Updated readme

view · edit · sidebar · attach · print · history
Page last modified on December 07, 2016, at 05:51 PM