view · edit · sidebar · attach · print · history

< Niklaus.20170419-virbac | Index | Niklaus.20170412-nomarketing >>

20170412-nomarketing

Summary

  • ODDB: Problems passing swissmedic_feed
  • drugshortage should not generate mail if nothing relevant changed
  • Add some meta tags
  • Port virbac to use SBSM with rack
  • Keep in Mind

Commits

Index

ODDB: Problems passing swissmedic_feed

Got the error offline mode: enter name=value pairs on standard input with import_daily. Also the same problem with jobs/update_textinfo_swissmedicinfo. Why? It looks for me, as we have a problem with the CGI used. See also http://dev.ywesee.com/Yasu/20160720-non-flavor-url-sbsm-fix-encoding-error-sandoz-xmlconv-bbmb-ch#sbsm-argv-violation-issue SBSM ARGV violation.

Pushed commit Must use CGI without offline prompt

drugshortage should not generate mail if nothing relevant changed

drugshortage should

  • not list all GTIN of analysed drugs
  • not generate an email if no relevant changes are detected (HTML file differs from day to day in its header)

Looking at failed unit tests made me think, that requiring util/session in src/plugin/shortage.rb was a bad idea. Settting the @flavour to 'gcc'. Running test/suite.rb and jobs/update_drugshortage before committing changes.

Pushed the following commits

Did see a lot of errors like

rss/fachinfo 68: rescue #<NoMethodError: undefined method `html' for nil:NilClass> for rss/fachinfo 68: #<ODBA::Stub:70262122293060#29727220 @odba_class= @odba_containe=70262132828560#21>: backtrace is: 
  /var/www/oddb.org/vendor/ruby/2.4.0/gems/htmlgrid-1.1.3/lib/htmlgrid/template.rb:109:in `template_html'
  /var/www/oddb.org/vendor/ruby/2.4.0/gems/htmlgrid-1.1.3/lib/htmlgrid/template.rb:122:in `to_html'
  /var/www/oddb.org/src/view/rss/fachinfo.rb:61:in `item_to_html'
  /var/www/oddb.org/src/view/rss/fachinfo.rb:89:in `block (2 levels) in to_html'
  /var/www/oddb.org/src/view/rss/fachinfo.rb:83:in `each'
  /var/www/oddb.org/src/view/rss/fachinfo.rb:83:in `block in to_html'

when running import_daily. Investigation the problem by placing a pry statement there. Error is in the post process job.

Pushed commits

Found the following entries in the log files

@4000000058f6108237494c24 ODDB::View::Ajax::SwissmedicCat::COMPONENTS[[1, 11]] in create(patent_protected)
@4000000058f610823760b06c error in SBSM::Session#http_headers: /fr/mobile/ajax_swissmedic_cat/reg/41655/seq/04/pack/089
@4000000058f61082377699cc NoMethodError
@4000000058f610823776c4c4 undefined method `strftime' for nil:NilClass
@4000000058f6108237770efc /var/www/oddb.org/vendor/bundle/ruby/2.4.0/gems/sbsm-1.3.0/lib/sbsm/lookandfeel.rb:121:in `format_date'
@4000000058f61082377712e4 /var/www/oddb.org/src/view/ajax/swissmedic_cat.rb:149:in `patent_protected'
@4000000058f61082377712e4 /var/www/oddb.org/vendor/bundle/ruby/2.4.0/gems/htmlgrid-1.1.3/lib/htmlgrid/composite.rb:83:in `create'
@4000000058f61082377716cc /var/www/oddb.org/vendor/bundle/ruby/2.4.0/gems/htmlgrid-1.1.3/lib/htmlgrid/composite.rb:284:in `compose_component'
@4000000058f6108237774d7c /var/www/oddb.org/vendor/bundle/ruby/2.4.0/gems/htmlgrid-1.1.3/lib/htmlgrid/composite.rb:213:in `block in compose'
@4000000058f610823b97beb4 error in SBSM::Session#to_html: /fr/mobile/ajax_swissmedic_cat/reg/41655/seq/04/pack/097
@4000000058f6108300133fbc NoMethodError
@4000000058f6108300136ab4 undefined method `strftime' for nil:NilClass

Fixed it with the commit Avoid nil when no patent.expiry_date given

Add some meta tags

Must add the following meta tags for oddb.org

  • DE: <meta name="apple-itunes-app" content="app-id=687642725"/>
  • FR: <meta name="apple-itunes-app" content="app-id=712891884"/>

Pushed commit Add meta tags for appled_app_id

Port virbac to use SBSM with rack

Adapting to newer watir 6.x syntax by changing browser.element.when_present.click to browser.element.wait_until(&:present?).click.

Working on making it start up again. login/logout methods moved from Session to App class.

view · edit · sidebar · attach · print · history
Page last modified on April 18, 2017, at 05:06 PM