view · edit · sidebar · attach · print · history

< Niklaus.20170919-search-limitations | Index | Niklaus.20170913-search-limitations >>

20170918-patinfo-error

Summary

  • patinfo error
  • drugshortage error
  • Improve settings to allow users to display only selected SL_categories
  • Keep in Mind

Commits

Index

patinfo error

Import-Daily lead to the following problem

Plugin: ODDB::TextInfoPlugin

Error: NoMethodError
Message: undefined method `split' for #<ODDB::PatinfoDocument:0x007f2acc062ce8>
Backtrace:
/var/www/oddb.org/src/model/patinfo.rb:87:in `add_change_log_item'
/var/www/oddb.org/src/plugin/text_info.rb:283:in `store_patinfo_change_diff'
/var/www/oddb.org/src/plugin/text_info.rb:295:in `store_patinfo_for_one_packages'
/var/www/oddb.org/src/plugin/text_info.rb:393:in `block (2 levels) in update_patinfo_lang'
/var/www/oddb.org/src/plugin/text_info.rb:376:in `each'
/var/www/oddb.org/src/plugin/text_info.rb:376:in `block in update_patinfo_lang'
/var/www/oddb.org/src/plugin/text_info.rb:373:in `each'
/var/www/oddb.org/src/plugin/text_info.rb:373:in `update_patinfo_lang'
/var/www/oddb.org/src/plugin/text_info.rb:1298:in `parse_textinfo'
/var/www/oddb.org/src/plugin/text_info.rb:1492:in `block in import_swissmedicinfo'
/var/www/oddb.org/src/plugin/text_info.rb:1491:in `each'
/var/www/oddb.org/src/plugin/text_info.rb:1491:in `import_swissmedicinfo'
/var/www/oddb.org/src/util/updater.rb:586:in `block in update_notify_simple'
/var/www/oddb.org/src/util/updater.rb:542:in `wrap_update'
/var/www/oddb.org/src/util/updater.rb:580:in `update_notify_simple'
/var/www/oddb.org/src/util/updater.rb:350:in `update_textinfo_swissmedicinfo'
/var/www/oddb.org/src/util/updater.rb:216:in `run'
jobs/import_daily:13:in `block in <module:Util>'
/var/www/oddb.org/src/util/job.rb:40:in `run'
jobs/import_daily:12:in `<module:Util>'
jobs/import_daily:11:in `<module:ODDB>'
jobs/import_daily:10:in `<main>'

Fixed with commit Comment out debug message which led to error

drugshortage error

we got the following error


Error: Errno::ENOENT
Message: No such file or directory @ unlink_internal - /var/www/oddb.org/data/html/drugshortage-2017.09.17.html
Backtrace:
/usr/local/ruby-2.4.0/lib/ruby/2.4.0/fileutils.rb:1334:in `unlink'
/usr/local/ruby-2.4.0/lib/ruby/2.4.0/fileutils.rb:1334:in `block in remove_file'
/usr/local/ruby-2.4.0/lib/ruby/2.4.0/fileutils.rb:1339:in `platform_support'
/usr/local/ruby-2.4.0/lib/ruby/2.4.0/fileutils.rb:1333:in `remove_file'
/usr/local/ruby-2.4.0/lib/ruby/2.4.0/fileutils.rb:697:in `remove_file'
/usr/local/ruby-2.4.0/lib/ruby/2.4.0/fileutils.rb:500:in `block in rm'
/usr/local/ruby-2.4.0/lib/ruby/2.4.0/fileutils.rb:499:in `each'
/usr/local/ruby-2.4.0/lib/ruby/2.4.0/fileutils.rb:499:in `rm'
/var/www/oddb.org/src/plugin/shortage.rb:135:in `report_shortage'
/var/www/oddb.org/src/plugin/shortage.rb:42:in `report'
/var/www/oddb.org/src/util/updater.rb:373:in `block in update_drugshortage'
/var/www/oddb.org/src/util/updater.rb:542:in `wrap_update'
/var/www/oddb.org/src/util/updater.rb:370:in `update_drugshortage'
/var/www/oddb.org/src/util/updater.rb:209:in `run'
jobs/import_daily:13:in `block in <module:Util>'
/var/www/oddb.org/src/util/job.rb:40:in `run'
jobs/import_daily:12:in `<module:Util>'
jobs/import_daily:11:in `<module:ODDB>'
jobs/import_daily:10:in `<main>'

Which was caused by trying to remove an inexistent file. Fixed withOnly remove @latest_shortage if exists

Improve settings to allow users to display only selected SL_categories

Fixing the unit and watir tests. The unit tests showed me, that I had to correct a problem in src/custom/lookandfeelwrapper.rb. Done with commit Fix error in lookandfeelwrapper.rb and unit-tests

Suddenly my login manager does not work any longer. Reinstalling the xorg-server using emerge --ask x11-base/xorg-server sddm

Fixed some watir specs with commit Fixed download and RSS watir tests for firefox and chrome

Now must fix another error reported by the watis tests

NoMethodError: undefined method `join' for "+41617054343":String                                                                          
        /var/www/oddb.org/src/view/suggest_address.rb:77:in `fon'                                                                         
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/htmlgrid-1.1.4/lib/htmlgrid/composite.rb:83:in `create'                                   
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/htmlgrid-1.1.4/lib/htmlgrid/composite.rb:284:in `compose_component'                       
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/htmlgrid-1.1.4/lib/htmlgrid/composite.rb:213:in `block in compose'                              
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/htmlgrid-1.1.4/lib/htmlgrid/composite.rb:209:in `each'                                          
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/htmlgrid-1.1.4/lib/htmlgrid/composite.rb:209:in `compose'                                        
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/htmlgrid-1.1.4/lib/htmlgrid/composite.rb:72:in `init'                                            
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/htmlgrid-1.1.4/lib/htmlgrid/form.rb:78:in `init'                                                 
        /var/www/oddb.org/src/view/suggest_address.rb:72:in `init'                                                                                
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/htmlgrid-1.1.4/lib/htmlgrid/component.rb:139:in `initialize'                                  
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/htmlgrid-1.1.4/lib/htmlgrid/composite.rb:76:in `new'                                          
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/htmlgrid-1.1.4/lib/htmlgrid/composite.rb:76:in `create'                                  
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/htmlgrid-1.1.4/lib/htmlgrid/composite.rb:284:in `compose_component'                      
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/htmlgrid-1.1.4/lib/htmlgrid/composite.rb:213:in `block in compose'                            
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/htmlgrid-1.1.4/lib/htmlgrid/composite.rb:209:in `each'                                        
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/htmlgrid-1.1.4/lib/htmlgrid/composite.rb:209:in `compose'                                      
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/htmlgrid-1.1.4/lib/htmlgrid/composite.rb:72:in `init'                                          
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/htmlgrid-1.1.4/lib/htmlgrid/component.rb:139:in `initialize'                          
        /var/www/oddb.org/src/view/publictemplate.rb:71:in `new'                                                                       
        /var/www/oddb.org/src/view/publictemplate.rb:71:in `content'          
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/htmlgrid-1.1.4/lib/htmlgrid/composite.rb:83:in `create'
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/htmlgrid-1.1.4/lib/htmlgrid/composite.rb:284:in `compose_component'
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/htmlgrid-1.1.4/lib/htmlgrid/composite.rb:213:in `block in compose'       
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/htmlgrid-1.1.4/lib/htmlgrid/composite.rb:209:in `each'                                    
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/htmlgrid-1.1.4/lib/htmlgrid/composite.rb:209:in `compose'                                                       
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/htmlgrid-1.1.4/lib/htmlgrid/composite.rb:72:in `init'                                                           
        /var/www/oddb.org/src/view/publictemplate.rb:68:in `init' 
        /var/www/oddb.org/src/view/privatetemplate.rb:17:in `init'       
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/htmlgrid-1.1.4/lib/htmlgrid/component.rb:139:in `initialize'
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/sbsm-1.5.9/lib/sbsm/state.rb:241:in `new'
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/sbsm-1.5.9/lib/sbsm/state.rb:241:in `view'
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/sbsm-1.5.9/lib/sbsm/state.rb:174:in `to_html'
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/sbsm-1.5.9/lib/sbsm/session.rb:547:in `to_html'
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/sbsm-1.5.9/lib/sbsm/session.rb:279:in `block in process_rack'
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/sbsm-1.5.9/lib/sbsm/session.rb:209:in `synchronize'
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/sbsm-1.5.9/lib/sbsm/session.rb:209:in `process_rack'
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/sbsm-1.5.9/lib/sbsm/app.rb:127:in `call'     
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/rack-2.0.3/lib/rack/lint.rb:49:in `_call'
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/rack-2.0.3/lib/rack/lint.rb:37:in `call'
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/rack-2.0.3/lib/rack/show_exceptions.rb:23:in `call'
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/rack-2.0.3/lib/rack/content_length.rb:15:in `call'
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/rack-2.0.3/lib/rack/static.rb:149:in `call'                                                       
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/rack-2.0.3/lib/rack/tempfile_reaper.rb:15:in `call'                                                               
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/rack-2.0.3/lib/rack/tempfile_reaper.rb:15:in `call'
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/rack-2.0.3/lib/rack/tempfile_reaper.rb:15:in `call'
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/rack-2.0.3/lib/rack/lint.rb:49:in `_call'                
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/rack-2.0.3/lib/rack/lint.rb:37:in `call'
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/rack-2.0.3/lib/rack/show_exceptions.rb:23:in `call'
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/rack-2.0.3/lib/rack/chunked.rb:54:in `call'             
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/rack-2.0.3/lib/rack/content_length.rb:15:in `call'
        /var/www/oddb.org/vendor/ruby/2.4.0/gems/rack-2.0.3/lib/rack/handler/webrick.rb:86:in `service'
        /usr/local/ruby-2.4.0/lib/ruby/2.4.0/webrick/httpserver.rb:140:in `service'    
        /usr/local/ruby-2.4.0/lib/ruby/2.4.0/webrick/httpserver.rb:96:in `run'
        /usr/local/ruby-2.4.0/lib/ruby/2.4.0/webrick/server.rb:290:in `block in start_thread'
        ODDB::View::SuggestAddressForm::COMPONENTS[[0, 7]] in create(fon)
        ODDB::View::SuggestAddressComposite::COMPONENTS[[0, 1]] in create(ODDB::View::SuggestAddressForm)
        ODDB::View::SuggestAddress::COMPONENTS[[0, 3]] in create(content)
192.168.0.75 - - [18/Sep/2017 12:46:52] "GET https://oddb-ci2.dyndns.org/de/gcc/suggest_address/company/7601001001121/address/0/zone/companies HTTP/1.1" 500 159191 0.0293  "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.18 Safari/537.36"

This is fixed with commits

Running the evidentia spec tests, as we have over 10 errors . Why? Changing the used URL from https to http://evidentia.oddb-ci2.dyndns.org:8412 solves the problem.

Now I only have 4 errors

  • rspec ./spec/evidentia_spec.rb:73 # ch.oddb.org should list Levetiracetam Desitin at the top when searching for Levetiracetam Desitin
  • rspec ./spec/evidentia_spec.rb:79 # ch.oddb.org should list all SL products before the Non-SL
  • rspec ./spec/evidentia_spec.rb:150 # ch.oddb.org should contain a link to the fachinfo for Lamivudin-Zidovudin
  • rspec ./spec/evidentia_spec.rb:179 # ch.oddb.org should list trademark first e.g. Duodopa

Checking, whether these are real errors or not. Yes Duodopa appears at the top of the list under http://evidentia.oddb.org/de/evidentia/search/zone/drugs/search_query/Duodopa/search_type/st_combined but under we find http://evidentia.oddb-ci2.dyndns.org:8412/de/evidentia/search/zone/drugs/search_query/Duodopa/search_type/st_combined way below and the "Evidentia"-Icon is missing, too.

Found the culprit. The session was not properly passed to the sort filter. And it is needed there to the check whether the Evidentia LNF is selected or not.

Looks like this fixed at least partially the remaining problems. But I still have two errors in the evidentia watir tests.

  • spec ./spec/evidentia_spec.rb:83 # ch.oddb.org should list all SL products before the Non-SL
  • rspec ./spec/evidentia_spec.rb:153 # ch.oddb.org should contain a link to the fachinfo for Lamivudin-Zidovudin

Cleaning up some too verbose puts statements. Pushed commit Fix evidentia search.

Will rerun all watir tests. Hopefully we can push all changes tomorrow.

Having the following 23 failed watir test

rspec ./spec/admin_spec.rb[1:1] # ch.oddb.org should be possible to upload dummy_patinfo.pdf to a given package
rspec ./spec/admin_spec.rb[1:2] # ch.oddb.org should be possible to upload dummy_patinfo_2.pdf to a given package
rspec ./spec/admin_spec.rb:129 # ch.oddb.org should be possible to create a CompanyUser
rspec ./spec/changelog_spec.rb[1:4] # ch.oddb.org change_log should have a working link to  Patienteninformationinformation from the Patienteninformation diff
rspec ./spec/evidentia_spec.rb:83 # ch.oddb.org should list all SL products before the Non-SL
rspec ./spec/evidentia_spec.rb:153 # ch.oddb.org should contain a link to the fachinfo for Lamivudin-Zidovudin
rspec ./spec/paypal_spec.rb:86 # ch.oddb.org should be possible to checkout oddb.csv via paypal
rspec ./spec/paypal_spec.rb:144 # ch.oddb.org should return a correct link to a CSV file if the payment is okay
rspec ./spec/paypal_spec.rb:169 # ch.oddb.org should not download a CSV file if the payment was not accepted
rspec ./spec/paypal_spec.rb:185 # ch.oddb.org should be possible to cancel a paypal before login
rspec ./spec/paypal_spec.rb:198 # ch.oddb.org should be possible to cancel a paypal after login but before paying
rspec ./spec/pharmacies_spec.rb:52 # ch.oddb.org check pharmacy
rspec ./spec/rezept_and_instantsearch_spec.rb:400 # ch.oddb.org should contain remarks or interaction header only when present
rspec ./spec/rezept_and_instantsearch_spec.rb:452 # ch.oddb.org should not loose existing comment after adding a new prescription
rspec ./spec/rezept_and_instantsearch_spec.rb:482 # ch.oddb.org should with four medicaments
rspec ./spec/rezept_and_instantsearch_spec.rb:509 # ch.oddb.org should show the correct url after deleting a medicament
rspec ./spec/rezept_and_instantsearch_spec.rb:571 # ch.oddb.org should be possible to print a presciption with 10 drugs
rspec ./spec/searchbar_spec.rb[1:2] # ch.oddb.org should be possible to find 1,25-Dihydroxycholecalciferol when searching via 125 in analysen
rspec ./spec/searchbar_spec.rb:153 # ch.oddb.org should work with the privatetemplate searchbar
rspec ./spec/searchbar_spec.rb:339 # ch.oddb.org should show no drugs for Fortex via unwanted effects search
rspec ./spec/searchbar_spec.rb:391 # ch.oddb.org should set best_result when searching Rivoleve via search_type
rspec ./spec/smoketest_spec.rb:220 # ch.oddb.org should find redirect an iphone to the mobile flavor
rspec ./spec/smoketest_spec.rb:345 # ch.oddb.org should download the example
view · edit · sidebar · attach · print · history
Page last modified on September 18, 2017, at 07:49 PM