view · edit · sidebar · attach · print · history

< Niklaus.20171113-oddb-redesign | Index | Niklaus.20171107-oddb-redesign >>

20171108-fix-swissmedic

Summary

  • oddb.org needs some minor redesign
  • Fix rapflag bugs
  • Fix "undefined method `push' for nil:NilClass" in update_swissmedic
  • Keep in Mind

Commits

Index

Fix "undefined method `push' for nil:NilClass" in update_swissmedic

Got the following error while running import_daily

Plugin: ODDB::SwissmedicPlugin

Error: NoMethodError
Message: undefined method `push' for nil:NilClass
Did you mean?  puts
Backtrace:
/var/www/oddb.org/vendor/ruby/2.4.0/gems/odba-1.1.2/lib/odba/stub.rb:112:in `method_missing'
/var/www/oddb.org/src/model/package.rb:273:in `create_part'
/var/www/oddb.org/src/plugin/swissmedic.rb:1133:in `update_package'
/var/www/oddb.org/src/plugin/swissmedic.rb:1269:in `update_all_sequence_info'
/var/www/oddb.org/src/plugin/swissmedic.rb:1290:in `block in update_registrations'
/var/www/oddb.org/src/plugin/swissmedic.rb:1277:in `each'
/var/www/oddb.org/src/plugin/swissmedic.rb:1277:in `each_with_index'
/var/www/oddb.org/src/plugin/swissmedic.rb:1277:in `update_registrations'
/var/www/oddb.org/src/plugin/swissmedic.rb:330:in `update'
/var/www/oddb.org/src/util/updater.rb:437:in `block in update_swissmedic'
/var/www/oddb.org/src/util/updater.rb:542:in `wrap_update'
/var/www/oddb.org/src/util/updater.rb:435:in `update_swissmedic'
/var/www/oddb.org/src/util/updater.rb:218:in `run'
jobs/import_daily:13:in `block in <module:Util>'
/var/www/oddb.org/src/util/job.rb:40:in `run'
jobs/import_daily:12:in `<module:Util>'
jobs/import_daily:11:in `<module:ODDB>'
jobs/import_daily:10:in `<main>'

Adding a pry breakpoint and running bundle-240 exec ruby-240 jobs/import_swissmedic_only locally. It takes too long, dropping and reloading the database of thinpower (yesterdays dump). Restarting import.

Found the reason: parts is a Part and not an array. Adding a workaround and restarting the import_daily.

Pushed commit Workaround if package.parts is not an array

oddb.org needs some minor redesign

Pulled the changes on thinpower and restarted the concerned LNFs.

Must fix running the unit tests. Done with commits

Added a zone naviagation for interactions Add zone_navigation for interactions

Align the ODDB logo left with commit Align logo left unless in home

Must unify the sponsor and company_logo. These are the criterias:

  • If a user is logged in, no logo is shown (unless he is the user of company that has a logo)
  • If it belonges to flavor that is sponsored (eg. evidentia/desitin) display the logo of this company
  • If we have a global sponsor, display its logo
  • else show google ad

Pushed commit Align logo left in home_interactions

Fixed a minor problem with commit Don't show tootip for Selbstbehalt

Fix rapflag bugs

Must add LTC and BCH as default currencies, when config.yml does not specify any. Also must ignore yet another pattern. Done with commits

view · edit · sidebar · attach · print · history
Page last modified on November 08, 2017, at 03:41 PM