Index>

20171108-fix-swissmedic

Summary

• oddb.org needs some minor redesign
• Fix rapflag bugs
• Fix "undefined method `push' for nil:NilClass" in update_swissmedic
• Keep in Mind

Commits

• https://github.com/ngiger/rapflag/commit/67db6ab4506a94aed944e476528c4b1976302dd9 Add LTC and BCH to list of default currencies
• https://github.com/ngiger/rapflag/commit/4ec71627a651f6b3142bd99c7e2b072baf90738c ignore entries like Bitcoin Gold snapshot step3 on Funding wallet fro
• https://github.com/ngiger/rapflag/commit/29ba132d12751831bc820e9ff38c07808872656a Bump version to 1.0.7
• https://github.com/ngiger/oddb.org/commit/943c420858663a9ae3ca717a191cd93c31f23896 Fix unit tests for views
• https://github.com/ngiger/oddb.org/commit/f3d7043b11939a3423ebb93b61cc339ca61ca71d Fix unit test for state logo
• https://github.com/ngiger/oddb.org/commit/1ac7e92ebd3876d29506085beb0d9b36346c7ff6 Workaround if package.parts is not an array
• https://github.com/ngiger/oddb.org/commit/190b70b0dac00ac8110eb4404295aeda011119ef Add zone_navigation for interactions
• https://github.com/ngiger/oddb.org/commit/8016b9c6846bedbbc5ba7a199f693780d6d16410 Align logo left unless in home
• https://github.com/ngiger/oddb.org/commit/d2ccb945d0e7c61554c3d4148c68ef0854beaf50 Align logo left in home_interactions
• https://github.com/ngiger/oddb.org/commit/d76c71c234cd05abea4c5b0a68dee4fbfe05e709 Don't show tootip for Selbstbehalt

Index

• Fix "undefined method `push' for nil:NilClass" in update_swissmedic
• oddb.org needs some minor redesign
• Fix rapflag bugs

Fix "undefined method `push' for nil:NilClass" in update_swissmedic

Got the following error while running import_daily

Plugin: ODDB::SwissmedicPlugin

Error: NoMethodError
Message: undefined method `push' for nil:NilClass
Did you mean?  puts
Backtrace:
/var/www/oddb.org/vendor/ruby/2.4.0/gems/odba-1.1.2/lib/odba/stub.rb:112:in `method_missing'
/var/www/oddb.org/src/model/package.rb:273:in `create_part'
/var/www/oddb.org/src/plugin/swissmedic.rb:1133:in `update_package'
/var/www/oddb.org/src/plugin/swissmedic.rb:1269:in `update_all_sequence_info'
/var/www/oddb.org/src/plugin/swissmedic.rb:1290:in `block in update_registrations'
/var/www/oddb.org/src/plugin/swissmedic.rb:1277:in `each'
/var/www/oddb.org/src/plugin/swissmedic.rb:1277:in `each_with_index'
/var/www/oddb.org/src/plugin/swissmedic.rb:1277:in `update_registrations'
/var/www/oddb.org/src/plugin/swissmedic.rb:330:in `update'
/var/www/oddb.org/src/util/updater.rb:437:in `block in update_swissmedic'
/var/www/oddb.org/src/util/updater.rb:542:in `wrap_update'
/var/www/oddb.org/src/util/updater.rb:435:in `update_swissmedic'
/var/www/oddb.org/src/util/updater.rb:218:in `run'
jobs/import_daily:13:in `block in <module:Util>'
/var/www/oddb.org/src/util/job.rb:40:in `run'
jobs/import_daily:12:in `<module:Util>'
jobs/import_daily:11:in `<module:ODDB>'
jobs/import_daily:10:in `<main>'

Adding a pry breakpoint and running bundle-240 exec ruby-240 jobs/import_swissmedic_only locally. It takes too long, dropping and reloading the database of thinpower (yesterdays dump). Restarting import.

Found the reason: parts is a Part and not an array. Adding a workaround and restarting the import_daily.

Pushed commit Workaround if package.parts is not an array

oddb.org needs some minor redesign

Pulled the changes on thinpower and restarted the concerned LNFs.

Must fix running the unit tests. Done with commits

• Fix unit tests for views
• Fix unit test for state logo

Added a zone naviagation for interactions Add zone_navigation for interactions

Align the ODDB logo left with commit Align logo left unless in home

Must unify the sponsor and company_logo. These are the criterias:

• If a user is logged in, no logo is shown (unless he is the user of company that has a logo)
• If it belonges to flavor that is sponsored (eg. evidentia/desitin) display the logo of this company
• If we have a global sponsor, display its logo
• else show google ad

Pushed commit Align logo left in home_interactions

Fixed a minor problem with commit Don't show tootip for Selbstbehalt

Fix rapflag bugs

Must add LTC and BCH as default currencies, when config.yml does not specify any. Also must ignore yet another pattern. Done with commits

• Add LTC and BCH to list of default currencies
• ignore entries like Bitcoin Gold snapshot step3 on Funding wallet fro
• Bump version to 1.0.7