20110915-debug-recycle_object_error-migel

<< | Index | >>

1. Debug Recycle object error migel
2. Update sort function

Goal/Estimate/Evaluation:

• Debug importer migel / 90% / 80%

Milestones

1. Debug RangeError
2. Debug Another error
3. Importer job

ToDo

• require 'migel/util/m10l_document' problem in multilingual.rb
• require 'oddb/util/m10l_document' problem in model_super.rb

Debug Recycle object error migel

Next

• Check which objects are sweeped in migel server side and oddb client side
• Find how to protect the objects from GC sweeper

Note

• GC happens in both migeld and oddbd
• http://oddb.masa.org/de/gcc/migel_search/migel_code/170103001

Experiment

• if GC.disable in both migeld and oddbd, the following result results in memory overflow
• http://oddb.masa.org/de/gcc/migel_search/migel_code/050703001

Possible solution

1. kill sort function
2. send a request every time to migel server and get the sorted object
3. keep objects from GC somehow
4. do not use Undumped DRbObject (call by value)

Update sort function

Concept

• send a request everytime to get sorted objects from oddbd to migeld

Note

• When the sort function is called the following links are created
  • http://oddb.masa.org/de/gcc/sort/state_id/70145272639220/sortvalue/ean_code
  • http://oddb.masa.org/de/gcc/sort/state_id/69950361079880/sortvalue/pharmacode
• event: sort
• key: stateid, sortvalue

Idea

1. Change the created url for sort
2. Sort items after getting migelid object
3. put the sortvalue key and value in the url
4. migel server code is not necessary to be updated

Experiment

• lib/migel/model/items.rb

  def initialize(product, sortvalue = nil)
    if product and items = product.items
      @sortvalue = sortvalue
...

  def sort_by
    # This is called at the first time when a search result is shown
    @list.sort_by do |record|
      if @sortvalue
        record.send(@sortvalue.to_sym).to_s
      else
        record.pharmacode
      end
    end

• src/state/global.rb

      def migel_search
        if migel_code = @session.user_input(:migel_code) and product = @session.search_migel_products(migel_code).first
          #ODDB::State::Migel::Items.new(@session, ODDB::Migel::Items.new(product))
          ODDB::State::Migel::Items.new(@session, ODDB::Migel::Items.new(product, @session.user_input(:sortvalue)))
...

Access

• http://oddb.masa.org/de/gcc/migel_search/migel_code/153050001

• http://oddb.masa.org/de/gcc/migel_search/migel_code/153050001/sortvalue/ean_code

Note

• the comparison value is changed into String by 'to_s' method
• this should be update in the case of price
• Two ways are there to show products list
  1. normal search from A-Z: http://oddb.masa.org/de/gcc/migel_search/migel_code/153050001
  2. search box: http://oddb.masa.org/de/gcc/search/zone/migel/search_query/CONTAM#best_result
• The first sort function is implemented (probably) in HtmlGrid, but anyway Model#sort_by method is called (ODDB::Migel::Items#sort_by) that is called from HtmlGrid::List#sort_model
• General sort function of header is defined in HtmlGrid#sort_link

Experiment

• src/view/migel/items.rb

  def sort_link(header_key, matrix, component)
    link = HtmlGrid::Link.new(header_key, @model, @session, self)
    link.href = @lookandfeel._event_url(:migel_search, [:migel_code, @model.first.migel_code, :sortvalue, component.to_s])
    link
  end

Access

• http://oddb.masa.org/de/gcc/migel_search/migel_code/153050001

Result

• The header link becomes (for example) http://oddb.masa.org/de/gcc/migel_search/migel_code/15.30.50.00.1/sortvalue/ean_code

Note

• But this does not reverses in the 2nd click
• And this does not appropriate for the box search result like http://oddb.masa.org/de/gcc/search/zone/migel/search_query/CONTAM#best_result

Next

• How to reverse in the 2nd click

Experiment

• src/state/global.rb

      def migel_search
        if migel_code = @session.user_input(:migel_code) and product = @session.search_migel_products(migel_code).first
          sort_key = @session.user_input(:sortvalue) || @session.user_input(:reverse)
          reverse  = @session.user_input(:reverse)
          ODDB::State::Migel::Items.new(@session, ODDB::Migel::Items.new(product, sort_key, reverse))

• src/model/migel/items.rb

class Items
  attr_reader :price, :qty, :unit, :pointer_descr
  def initialize(product, sortvalue = nil, reverse = nil)
    if product and items = product.items
      @sortvalue = sortvalue
      @list = items.values
      @reverse = reverse
...

  def sort_by
    # This is called at the first time when a search result is shown
    @list.sort_by do |record|
      if @sortvalue
        if @sortvalue == 'ppub'
          record.ppub.to_f
        else
          record.send(@sortvalue.to_sym).to_s
        end
      else
        record.pharmacode
      end
    end
    #reverse_sort! if @reverse
    if @reverse
      reverse_sort!
    end
    @list
  end

• src/view/migel/items.rb

  def sort_link(header_key, matrix, component)
    link = HtmlGrid::Link.new(header_key, @model, @session, self)
    sort = @session.user_input(:sortvalue) ? :reverse : :sortvalue
    link.href = @lookandfeel._event_url(:migel_search, [:migel_code, @model.first.migel_code.gsub('.',''), sort, component.to_s])
    link
  end
  def reverse_sort!
    sort! do |a,b|
      a.send(@sortvalue.to_sym).to_s <=> b.send(@sortvalue.to_sym).to_s
    end
  end

Access

• http://oddb.masa.org/de/gcc/migel_search/migel_code/153050001

Result

• failed