201112227-fix-feedback-event-exportCsv-updateSwissmedic-debug-odba-hash-iteration-error-ruby193-oddb_org

<< Masa.20111228-check-importer-exporter-ruby193-oddb_org | 2011 | Masa.20111223-fix-patinfo-fachinfo-invoicer-ruby193-oddb_org >>

Goal

• check all the importer exporter on Ruby 1.9.3 oddb.org / 70% / 50%

Milestones

1. export_csv (oddb.csv, oddb2.csv)
2. swissmedic importer bug
3. check patinfo error
4. check update_swissmedic
5. update_swissmedic_followers
   1. (update_package_trade_status_by_swissindex)
   2. (exporter.mail_swissmedic_notifications)
6. update_bsv_followers
   1. export_oddb_csv
   2. export_oddb2_csv
7. export daily
   1. mail_patinfo_invoices
   2. mail_fachinfo_log
   3. export_csv

Commits

• Skip feedbacks event with pointer link (oddb.org)
• Fix encoding error and undefined de method error during export_csv (oddb.org)
• Updated update_swissmedic to be executed only if the latest file is different from a downloaded file (oddb.org)
• Updated the conditin to run update_swissmedic in the case of no latest xls file (oddb.org)
• Debugged Hash iteration error during cleaning @fetched and @prefetched objects (odba)

Debug Hash iteration error

Refer to http://dev.ywesee.com/wiki.php/Choddb/Ruby193p0#HashError20111227

How to debug

1. A hash (@fetched, @prefetched) is used in the part where the hash iteration error happens.
2. The _clean method is only the other part where @fetched and @prefetched (Hash) are used.
3. Then I tested a simple sample where the same thread situation was constructed.
4. The same error happens on Ruby 1.9 but it works on Ruby 1.8 without error. Then I get to believe it is a bug.

Note

• So basically the Mutex is back, but the file lock is not back
• This was a bug of in ODBA

Sample script to reproduce the bug

• Attach:hash_ite_bug.rb.20111227.txt