20130618-PIKapitel-2

<< | Index | >>

Summary

• Bei einigen PIs fehlt die Rubrik. „Wann wird … angewendet?“

Commits

• https://github.com/ngiger/oddb.org/commit/0dceb75c7e2b62ccdcb7e38a4bfac86915a099ad Fix Bei einigen PIs fehlt die Rubrik. „Wann wird … angewendet?“
• https://github.com/ngiger/vagrant-oddb_org/commit/0c6dee8b1858ca6de17abf002a6b7acd0fe3b9df Cleanup: Enforce rule with basePort/last digits of IP
• https://github.com/ngiger/vagrant-oddb_org/commit/424d300cf8f56ca0d4dfae866e7405e267d9e084 Fix: Use correct mail.user for git user.email
• https://github.com/ngiger/oddb.org/commit/8c7dd4ea65dc940fb39546455012320370b4202d Added coverage to rake
• https://github.com/ngiger/oddb.org/commit/065940e3419f63a801a244de83a5e014ee086b8c make Rakefile ruby 1.9.3 ready and build quanty before calling rake test

Index

• Die Rubrik. „Wann wird … angewendet?“ fehlt
• oddb.org: Make rake test run under ruby 1.9.3

Die Rubrik. „Wann wird … angewendet?“ fehlt

• Rebuilt all indices sudo -u apache ruby jobs/rebuild_indices.

Log-File ist: Attach:rebuild.txt

Work to to as per E-Mail from zeno

 
Bei einigen PIs fehlt die Rubrik.
„Wann wird … angewendet?“
d.h. beim importieren von
jobs/update_textinfo_swissmedicinfo
wird mittels der Regex das Kapitel
„Wann wird … angewendet?“
nicht erkannt. Du siehst die Möglichkeiten der Titel für PIs (DE und FR) hier:
http://www.swissmedic.ch/zulassungen/00171/02288/index.html?lang=de&download=NHzLpZeg7t,lnp6I0NTU042l2Z6ln1acy4Zn4Z2qZpnO2Yuq2Z6gpJCDd312fmym162epYbg2c_JjKbNoKSn6A--
Yasuhiro hat wohl vergessen das Kapitel
„Wann wird … angewendet?“
zu erkennen, mittel Regex.
Beispiele: (Markennamensuche) wo das Problem auftritt (DB Stand 16.6.2013).
Traumeel
Vertigoheel
Notakehl
Virburcol N

Schritte:
1. Problem bei Dir Lokal bestätigen.
2. Code verbessern.
3. Verbesserung lokal bestätigen.
4. Commiten und mir sagen, damit ich es Online überprüfen kann.

Die Option um PIs nochmals zu parsen ist:
jobs/update_textinfo_swissmedicinfo --reparse --target=pi 52651 41436
Die Nummern sind die 5-stelligen Swissmedic-Nummern, welche Du siehst
wenn Du auf ch.oddb.org als Admin eingeloggt bist, auf der Linken
Seite. Du findest die gleichen Nummern auch in der PI im Kapitel
"Zulassungsnummer" (siehe auch zusätzlich PDF Doku-Link von
Swissmedic).
Italienisch Parsen wir zur Zeit nicht. Nur DE und FR.

• Rerun the import using @@sudo -u apache ruby /var/www/oddb.org/jobs/update_textinfo_swissmedicinfo --reparse --target=pi 62285

@@

• To navigate to the example of Zeno 62285, used the following link http://oddb.niklaus.org/de/gcc/drug/reg/62285/seq/01
• Could reproduce the problem locally as http://oddb.niklaus.org/de/gcc/patinfo/reg/62285/seq/01 shows the info as it should see
• With Notakehl http://oddb.niklaus.org/de/gcc/patinfo/reg/50290/seq/02 I see the problem
• run sudo -u apache ruby /var/www/oddb.org/jobs/update_textinfo_swissmedicinfo --reparse --target=pi 50290. Takes about 13 minutes.
• Tried to run ruby test/test_plugin/text_info.rb but got 27 tests, 47 assertions, 11 failures, 1 errors, 0 skips
• Tried to run rake test but got

<..>
/opt/src/oddb.org/src/model/dose.rb:6:in `require': cannot load such file -- util/quanty (LoadError)
        from /opt/src/oddb.org/src/model/dose.rb:6:in `<top (required)>'
        from /opt/src/oddb.org/src/plugin/bsv_xml.rb:11:in `require'
        from /opt/src/oddb.org/src/plugin/bsv_xml.rb:11:in `<top (required)>'
        from /opt/src/oddb.org/src/util/updater.rb:9:in `require'
        from /opt/src/oddb.org/src/util/updater.rb:9:in `<top (required)>'
        from /opt/src/oddb.org/src/state/admin/init.rb:8:in `require'
        from /opt/src/oddb.org/src/state/admin/init.rb:8:in `<top (required)>'
        from /opt/src/oddb.org/src/state/admin/global.rb:5:in `require'
        from /opt/src/oddb.org/src/state/admin/global.rb:5:in `<top (required)>'
        from /opt/src/oddb.org/src/state/admin/galenicgroups.rb:5:in `require'
        from /opt/src/oddb.org/src/state/admin/galenicgroups.rb:5:in `<top (required)>'
        from /opt/src/oddb.org/src/state/admin/root.rb:6:in `require'
        from /opt/src/oddb.org/src/state/admin/root.rb:6:in `<top (required)>'
        from /opt/src/oddb.org/src/state/admin/login.rb:8:in `require'
        from /opt/src/oddb.org/src/state/admin/login.rb:8:in `<top (required)>'
        from /opt/src/oddb.org/src/state/paypal/checkout.rb:6:in `require'
        from /opt/src/oddb.org/src/state/paypal/checkout.rb:6:in `<top (required)>'
        from /opt/src/oddb.org/src/state/drugs/register_download.rb:6:in `require'
        from /opt/src/oddb.org/src/state/drugs/register_download.rb:6:in `<top (required)>'
        from /opt/src/oddb.org/src/state/drugs/result.rb:8:in `require'
        from /opt/src/oddb.org/src/state/drugs/result.rb:8:in `<top (required)>'
        from /opt/src/oddb.org/test/test_state/drugs/test_result.rb:12:in `require'
        from /opt/src/oddb.org/test/test_state/drugs/test_result.rb:12:in `<top (required)>'

• Wrote a simple unit test, where I included the (private) procedure detect_chapter from patinfo_hpricot.rb. Attach:text_chapter.rb
• The culprit are non-word characters like ® (trademark) or ',' in the name.
• Use http://rubular.com/ to find a better regexp, See Use .* instead [\w\s]
• Running unit tests ruby ext/fiparse/test/test_patinfo_hpricot.rb yields 10 errors
• Added a new test. There are 31 not correctly identified cases when compared to the specification
• Running the patches locally did not fix the problem
• Delete PI againg. Restarted partial rebuild using pry. Did not work
• Restarted the VM. Now the update_textinfo_swissmedicinfo fails. Reason: update_textinfo_swissmedicinfo delegates the parsing to the service ch.oddb-fiparse!!
• Removed the pry statements. Restarted the VM and update_textinfo_swissmedicinfo again.
• Now this problem is solved. Asked Zeno to pull this commit. See also

oddb.org: Make rake test run under ruby 1.9.3

• While waiting for jobs to complete, upgraded the rakefile of oddb.org to ruby 1.9.3. Updated readme.
• Corrected data/quanty/extconf.rb to run under Ruby 1.9.3 (This will brake my puppet file install_yus.sh!)
• Use simplecov instead of rcov. Added test/test_helper.rb to start simplecov
• Added a rake quanty target to the rakefile
• Make rake test depend on quanty
• Tried to make it use Travis-CI. link okay, but no build visible yet
• Coverage reports shows up
• rake test is not good yet 59 tests, 56 assertions, 10 failures, 3 errors, 0 skips
• Don't know whether test/suite.rb is completely replace by using rake test
  • Manually calling gem install test-unit && ruby test/suite.rb returns 1953 tests, 2499 assertions, 106 failures, 300 errors
  • We should fix these errors!
  • Coverage using ruby test/suite.rb returns
    • All Files (44.5% covered at 2.87 hits/line)
    • 607 files in total. 39024 relevant lines. 17364 lines covered and 21660 lines missed
  • Coverage using rake test returns
    • All Files (34.47% covered at 0.56 hits/line)
    • 269 files in total. 20629 relevant lines. 7111 lines covered and 13518 lines missed
• Added a Jenkins-CI for ODDB.ORG http://ngiger.dyndns.org/jenkins/view/Alle/job/oddb.org/ (based on my branch of oddb.org)