20130814-wrong-patinfo2

<< | Index | >>

Summary

• Fix error comparison of Array with Array failed when running update_swissmedicno_fi_pi
• oddb.org should be able to send the reports to more than 2 e-mail addresses

Commits

• https://github.com/ngiger/oddb.org/commit/1efaba85f06388fa9a867cdb87f86814ff91a8a5 Fixed nil. Add logfile for check
• https://github.com/ngiger/oddb.org/commit/a3b93af770081a416dc54ffdc95baed2824ffc68 Fix changed return value check_swissmedicno_fi_pi
• https://github.com/ngiger/oddb.org/commit/92c2c84aa9a56c90384d5d8d34e36c2fb078a950 Less false positive when checking patinfo

Index

• oddb.org should be able to send the reports to more than 2 e-mail addresses
• Fix error comparison of Array with Array failed when running update_swissmedicno_fi_pi

oddb.org should be able to send the reports to more than 2 e-mail addresses

When running import the e-mail-addresses get picked up via test/testenvironment1.rb, where they default to the git user-email.

Changed the configuration of my hieradata to use ngiger@ywesee.com. Mails from importer come and arrive now via ywesee.

Fix error comparison of Array with Array failed when running update_swissmedicno_fi_pi

This error is quite fatal as in this moment all the wrong patinfo pointer are deleted, but no report has be sent. We should probably create a logfile and store the iksnrs to be reimported there.

I am loading the /var/backup/thinpower/db/postgresql/August-2013/013-08-12/22:00-postgresql_database-oddb.org.ruby193-backup.gz and running the import here on my vm again to get the list of iksrns to import. See Attach:check_si_fi_pi_201308141007.txt

Also with my (local) changes I creatd the log log/check_swissmedicno_fi_pi/2013/08.log. Investigating the problem, that the report does not send any mail. Ran the check job after the update job and it did not find any errors.

Commit Fixed nil. Add logfile for check to enable running the update online.

Still having the problem that importer & new jobs don't send any e-mail. This worked yester till 18:23. (But my commit was at 18:35). Reverted to 70f65408915d3b93e664a87e62ca5e6dcf206a05 and reports worked again. After checking out master the mails arrived again (verified that is was from a newer commit as it had the new line 0 wrong metatags:. Running check and update. Both sent a mail, but update had the following error:

Plugin: ODDB::TextInfoPlugin
Error: NoMethodError
Message: undefined method `[]' for true:TrueClass
Backtrace:
/var/www/oddb.org/src/plugin/text_info.rb:1040:in `block in update_swissmedicno_fi_pi'

Fixed with commit Fix changed return value check_swissmedicno_fi_pi

Found false positives when running checks online. Eg.g [["Dexalocal", "36231", "Dexalocal-F", :!patinfo,30219744.], ["Topsym", "37783", "Topsym-F", :!patinfo,30219924.]. Prepared patch to fix using

• split first word not only on space but also at '-' and ','
• compare case-insensitive

Loaded database dump from online, reimported missing patinfo. Will run the check first without my changes, then with my changes. First had 27 errors like online. Afterwards there were just 6 remains. Pushed commit Less false positive when checking patinfo