20131105-Index-Indications

<< | Index | >>

Summary

• Fix index indications

Commits

• https://github.com/ngiger/oddb.org/commit/002cd3c5bd165c3d4e326309c7166ade0da890df Avoid nil error while importing FI/PI updates
• https://github.com/ngiger/oddb.org/commit/077b6884b5798beb58634c2217c856ff9ef05274 Logging will append not overwrite the log file for textinfo.
• https://github.com/ngiger/oddb.org/commit/1d83c2c20b5c6532ca6e213f5c5300631be4426c Fixed test cases for indication tests
• https://github.com/ngiger/oddb.org/commit/9fd1adff68dc64f9760a0827a3b301faa379add8 Remove no longer availabe proc u for UTF-8 conversion
• https://github.com/ngiger/oddb.org/commit/b7676f84fdd6aad97939803ecd2053053633b18a Fix spelling

Index

• Fix index indications
• Error: Fach- und Patienteninfo Updates (swissmedicinfo.ch)
• Problems with yus under ruby 1.9

---

Problems with yus under ruby 1.9

As I restartet my VM, puppet installed some gems and broke yus. Therefore I tried to run the yus unit tests under 1.8.3 (all okay), 2.0 and a recent 1.9.3 ruby (p448).

After adding a Gemfile with minitest in the development group for the platform mri_19 the unit tests started to work, but I got 10 errors NoMethodError: undefined method `critical=' for Thread:Class.

The DependencyInjection gem needle is very old (from 2004) and many argue the DI is not needed with Ruby. See e.g. https://www.ruby-forum.com/topic/149098. Therefore it might be a good idea to get rid of needle.

The Guide.txt is also not clearly order and therefore I am working on the following points

1. let gemfile specify all needed gems to actually run yus
2. Order guide.txt to put all steps in the right order, e.g.
   1. configure postgres db before
   2. starting bin/yusd
3. requirement of "trust" for local user was not mentioned in the guide

Now yus seems to work quite find. yus_show ngiger@ywesee.com works.

Error: Fach- und Patienteninfo Updates (swissmedicinfo.ch)

Corrected logging to append, because we have two imports (FI/PI) each day!

Corrected error, because registration.expiration_date can be nil. Rerun import_daily.

Pushed commits Avoid nil error while importing FI/PI updates and Logging will append not overwrite the log file for textinfo

Fix index indications

Continuing work from last week.

Pushed some minor fixes Fix spelling and Remove no longer availabe proc u for UTF-8 conversion

Corrected unit tests for indications. Fixed test cases for indication tests

I think the error is simple. in src/util/language.rb the method to_s tests whether the object responds to empty instead of empty?. Added this change to my VM and rebuilding the indices.

Now I can search http://oddb-ci.dyndns.org/de/gcc?search_query=Reflux%C3%B6sophagitis&search_type=st_indication&flavor=gcc&language=de&event=search&state_id=69996969498440