20131118-FI-missing-breaks
<< | Index | >>
Summary
- FI 43385 (chapter/effects) has missing breaks
- Limit crawlers to 1,5 GB memory consumption
Commits
- https://github.com/ngiger/oddb.org/commit/bc471975374771f7de8fb55c65a091dd85170933 Updated Gemfile to use patched dbi from zdavatz/ruby-dbi
- https://github.com/ngiger/oddb.org/commit/9905cfce0e6c5b647da4e7b0a34d593dd933bf59 Minor fixe for test fi_57435_Baraclude
- https://github.com/ngiger/oddb.org/commit/62e66e03ab64e824ccf528550e8e2b58eaef8d84 (Partial) fix to handle line breaks in table cells
- https://github.com/ngiger/currency/commit/6218c18139908b1f7616cc5da2ee7cad1e41218b Make bin/currencyd load lib/curency
- https://github.com/ngiger/currency/commit/93af60ab73d4fbcbed433175ca93b4508d925d0c Added LICENSE
- https://github.com/ngiger/currency/commit/832ae33c0eac225835c36ddfe9b1a717df20753c Added missing dependencies for bin/currencyd
- https://github.com/ngiger/currency/commit/67d08a7e030eddb10455d61947a7d8b335aada78 Added small spec and Gemfile and support for travis-ci
Index
- FI 43385 (chapter/effects) has missing breaks
- Limit crawlers to 1,5 GB memory consumption
- Made ycurrency work with bundler and travis-CI
---
Made ycurrency work with bundler and travis-CI
Pushed a few commits
- https://github.com/ngiger/currency/commit/6218c18139908b1f7616cc5da2ee7cad1e41218b Make bin/currencyd load lib/curency
- https://github.com/ngiger/currency/commit/93af60ab73d4fbcbed433175ca93b4508d925d0c Added LICENSE
- https://github.com/ngiger/currency/commit/832ae33c0eac225835c36ddfe9b1a717df20753c Added missing dependencies for bin/currencyd
- https://github.com/ngiger/currency/commit/67d08a7e030eddb10455d61947a7d8b335aada78 Added small spec and Gemfile and support for travis-ci
Travis-CI is now okay. See https://travis-ci.org/ngiger/currency/builds/14149424.
Limit crawlers to 1,5 GB memory consumption
On thinpower the two processes /service/ch.oddb-crawler and /service/ch.oddb-google_crawler must be restarted when they use more than 1,5 GB memory.
The bash ulimit function should do the job. In /service/ch.oddb-crawler/run we find the statement ulimit -v 10240000 . The argument is in kB, which limits it to something like 9.8 GB. Changing the value to 1536000 should be have the desired effect. Restartet the two processes.
Updating my puppet receipts to ensure that all service have a default max memory usage of 1,5 GB.
Found that the currency daemon does not yet have a Gemfile.
FI 43385 (chapter/effects) has missing breaks
Pushed two commits laying around in my checkout. Updated Gemfile to use patched dbi from zdavatz/ruby-db and Minor fixe for test fi_57435_Baraclude
Extracted fi_43385_Doxycyclin.html from AipsDownload_latest and adding the chapter effects to the test suite.
After analysing the code paths (and /var/www/oddb.org/data/html/fachinfo/de/Doxycyclin-CIMEX_swissmedicinfo.yaml) on thinpower I see that we generate for the cell containing 'MHK-Werte (mg/l); MHK-Werte (mg/l); **Durchschnittswerte oder Bandbreite' effectively 3 paragraphs.
Analysing the generated HTML code at http://oddb-ci2.dyndns.org/de/gcc/fachinfo/reg/43385/chapter/effects we see however that this cell does not contain any HTML entity paragraph, but only an array of spans. Therefore I must change somewhere the rendering.
Changed src/view/chapter.rb (line 26) to return content.p instead of content.span. But now we have too much space between the rows as seen here:
Looking at the generated HTML code I see, that in this case I should generate <br> tags instead of <p>. But how?
Modified src/view/chapter.rb to return always the paragraph + <br>. The output looks good now. See here:
But there are tables, where it does not look very good. E.g. given here:
Committed fix (including unit test) via (Partial) fix to handle line breaks in table cells