201311119-FI-too-many-line-breaks

<< | Index | >>

Summary

• FI 43385 has too many line breaks
• Migeld did not yet run on my oddb-ci2

Commits

• https://github.com/ngiger/vagrant-oddb_org/commit/d59573e23c90d106672df4eedd941e9ffc1e234b Updated currency/yus/migel to use bundler. Ulimit services
• https://github.com/ngiger/migel/commit/10a77e963ace6bdcf196d8f98e6c9d73d239290c bin/migeld need pg to work
• https://github.com/ngiger/oddb.org/commit/f43561fd71403869629aeb779ace41bd50e81f82 Fix handling paragraphs/line-feeds in table

Index

• FI 43385 has too many line breaks
• Migeld did not yet run on my oddb-ci2

---

FI 43385 has too many line breaks

The cell "Anm" after "Teilweise empfindliche und mehrheitlich mässig empfindliche bakterielle Erreger (MHK-Wert >4–<16 mg/l)" has too many line breaks.

Okay. We need the following surgery in our code:

1. Replace style span for paragraphs by p (be as close as possible)
   1. This should get us rid of adding style="padding-bottom: 4px; white-space: normal; line-height: 1.4em for each paragraph.
   2. It might be necessary to introduce a new style for paragraphs inside a fachinfo or a fachinfo/chapter.
2. Fix css which adds too much white space after paragraphs

Also I have to be careful about handling empty paragraphs. A paragraph inside a table cell must contain a @&nbsp@ to occupy really a line!

After looking hard I found a solution which works nicely with my test chapter. But once I deployed the code to my oddb-ci2, a paragraph which should be   (surrounded by a span tag) is a single space character. Why? Fixed by returning   when paragraph is empty. This works now, because I also ignore "\n" in the analysed html code. I think now parsing is more HTML conform.

What is still missing that in the tables a few paragraphs should be italic, e.g Grampositive bakterielle Erreger. Also the line-spacing is questionable. But this should better be fixed with a CSS-based style-class.

Example see here:

Pushed commit Fix handling paragraphs/line-feeds in table

Migeld did not yet run on my oddb-ci2

I remarked that migeld did not run my new machine oddb-ci2. Finished porting it to bundler. Migel products are now shown, too. Pushed fixes of yesterday and today with commit Updated currency/yus/migel to use bundler. Ulimit services

Migel could not start, because the gem @pg@ was not present. Fixed with commit bin/migeld need pg to work