Index>

20140422-correct-oddb2xml

Summary

• oddb2xml creates 20'000 (almost duplicated) entries.
• field "Bemerkungen" of prescription is too large on iPad

Commits

• https://github.com/ngiger/oddb2xml/commit/779e8b1e2dfa875a9b9dbb9fe717f95571ff3b93 Orphan is now an xlsx file, too
• https://github.com/ngiger/oddb2xml/commit/cc511fdc1d58ed74afe6c486c6f6b5d146d2bd05 Bump version to 1.7.9 and adapte Gemfile.lock
• https://github.com/ngiger/oddb2xml/commit/d4371e57a8762219467589f52d8b0908de001f56 Avoid ArgumentError for sprintf
• https://github.com/ngiger/oddb2xml/commit/249661477a2e546c7f9378369224a15f9caf0c97 Add spec task to rake
• https://github.com/ngiger/oddb2xml/commit/977e1a99d9b3a1081f2c519850b3abc628b86ab5 Fix rspec

Index

• oddb2xml creates 20'000 (almost duplicated) entries
• field "Bemerkungen" of prescription is too large on iPad

Keep in Mind

• Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
• Search nach Anwendung (indications), z.B. Konjunktivitis, does not report all occurrences in the section "Anwendung" of Fachinfo. Probably index is corrupted or not set up correctly.
• Error: Patents with could not connect to www.swissreg.ch: #<Net::HTTPInternalServerError:0x007f8a7d69bb58>
• vagrant-oddb.org: cleanup installation for yus with ruby 1.8, logrotate.conf and local vhosts for tests
• add doc/resources/*/*.css from thinpower. Be aware of permissions and don't add obsolete files!

---

field "Bemerkungen" of prescription is too large on iPad

The field :prescription_comment is a textareas which has the CSS class wide, which is defined with width : 750px; height : 100px; in doc/resources/gcc/oddb.css. These values are not overwritten by in the mobile *.css like doc/resources/mobile/oddb.css.

To proceeed I will add all current *.css files from thinpower to the oddb. First saving a backup calling cp -rp doc/resources ~/backup.resourcea in /var/www/oddb.org. Then removing the obsolete definitions by calling (as root)

rm -rf doc/resources/swissmedic \
doc/resources/gerimedi \
doc/resources/innova \
doc/resources/provita \
doc/resources/schoenenberger \
doc/resources/sympany

oddb2xml creates 20'000 (almost duplicated) entries

The following errors must be fixed:

1. Running oddb2xml -t md fails (is orphan now a xlsx file?)
2. oddb_substances.xml and oddb_interactions.xml are empty
3. Running oddb2xml -a nonpharma -f dat file with /home/zeno/.gem/ruby/1.9.1/gems/oddb2xml-1.7.8/lib/oddb2xml/builder.rb:1091:in `%': invalid value for Integer(): "0707387007355" (ArgumentError)
4. Zeno reported that there are 20'000 duplicatede entries when using the -e option. A product like Zyvoxid is added once with SALECD "A" and once with SALECD "I"

The orphan file is now an XLSX-file too and we needed some minor changes in lib/oddb2xml/extractor.rb and lib/oddb2xml/downloader.rb to adapt to it. Running oddb2xml -e takes a long time again.

Pushed commits Orphan is now an xlsx file, too and Bump version to 1.7.9 and adapte Gemfile.lock

Thinking about on how we can improve the testing to avoid errors like nr 2 and 3 in our list. The following ideas came into my mind.

1. Create a section about testing in readme.md (or create a testing.md) with a small howto
2. Before releasing a new version
   1. run a script which runs all suggested combinations of oddb2xml and saving the results and all downloaded files for later access. These archives should have somewhere a backup.
   2. Manually compare these results with the new version
3. Maybe we should call the same script before changing anything to see only the changes added by our fixes, as many of the items may have changed. Specially if the old release was good and is several months old.

Pushed commit Avoid ArgumentError for sprintf

Made rspec pass again with commit Fix rspec

Added spec task to rake with commit Add spec task to rake

Looking around why we have duplicates I found the following stuff for Zyvoxid Filmtab in data/download:

data/download/oddb2xml_zurrose_transfer.dat:1122465312ZYVOXID Filmtabl 600 mg 10 Stk                    096114108275100A080190076805555800542
ata/download/swissindex_Pharma_DE.xml-      <ITEM DT="2013-06-22T00:00:00">
data/download/swissindex_Pharma_DE.xml-        <GTIN>7680555580054</GTIN>
data/download/swissindex_Pharma_DE.xml-        <PHAR>2465312</PHAR>
data/download/swissindex_Pharma_DE.xml-        <STATUS>A</STATUS>
data/download/swissindex_Pharma_DE.xml-        <STDATE>2002-01-16T00:00:00</STDATE>
data/download/swissindex_Pharma_DE.xml-        <LANG>DE</LANG>
data/download/swissindex_Pharma_DE.xml:        <DSCR>ZYVOXID Filmtabl 600 mg</DSCR>
data/download/swissindex_Pharma_DE.xml-        <ADDSCR>10 Stk</ADDSCR>
data/download/swissindex_Pharma_DE.xml-        <ATC>J01XX08</ATC>
data/download/swissindex_Pharma_DE.xml-        <COMP>
data/download/swissindex_Pharma_DE.xml-          <NAME>Pfizer AG</NAME>
data/download/swissindex_Pharma_DE.xml-          <GLN>7601001010604</GLN>
data/download/swissindex_Pharma_DE.xml-        </COMP>
data/download/swissindex_Pharma_DE.xml-      </ITEM>

Therefore I asking myself why we get a duplicate with STATUS I?