view · edit · sidebar · attach · print · history

Index>

20140602-fix-change-password

Summary

  • replace list of email receipents by configuration data in etc/oddb.yaml
  • Changing the password does not work anymore / Paypal problem with UTF-8
  • BAG-XML import did not work

Commits

Index

Keep in Mind
  • Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
  • I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
  • The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
  • One unit-test for searchbar fails and might be a clue why searching does not work correctly.
  • Added two skip in test/test_plugin/rss.rb. Why does the mocking not work there anymore?

---

BAG-XML import did not work

Setting latest on thinpower and oddb-ci to state of mai again. Restarting import_daily with more debugging info on oddb-ci2.

as admin must it must be able to reset the password of another user

Zeno tried (logged in as an admin) to change the password via http://ch.oddb.org/de/gcc/user/name/thomas.banz%40tc-informatik.ch and got the error 

Encoding::CompatibilityError incompatible character encodings:
ASCII-8BIT and UTF-8

Trying to reproduce the error on oddb-ci2 and looking for a unit test. I need to learn more about the sandbox.paypal.com to setup receivers and building a real unit-test. But then it should be possible to create real unit-tests which will check the show process.

Accessing de/gcc/user/name/thomas.banz%40tc-informatik.ch for an invalid user (at oddb-ci2), gives only the error NoMethodError undefined method `name' for nil:NilClass.

replace list of email receipents by configuration data in etc/oddb.yaml

Pushed changes as I had problems that

  • tracis-ci did not fail when a simplecov unit-test failed
  • simplecov made sometimes fail tests because they did not have enough coverage
  • simplecov made sometimes fail tests because coverage dropped a little bit since last commit

Will push changes to github and pulling then to thinpower. Will restart all ch.oddb services. But first must ensure that all mailing lists are correctly defined in etc/oddb.yaml.

Now I see that sending mails does not work on thinpower. Found following entries in /var/log/messages 

Jun  2 09:33:02 thinpower sSMTP[7655]: Unable to locate mail.ywesee.com
Jun  2 09:33:02 thinpower sSMTP[7655]: Cannot open mail.ywesee.com:25
Jun  2 09:33:02 thinpower cron[7652]: (apache) MAIL (mailed 55 bytes of output but got status 0x0001
)

This error does not come from oddb.org but another crontab job. But import-daily failed, because the @cfg variable was not initialized correctly. Fixed with commit Fixed import-daily as it accessed unitialized mail_from

Ensured that log.notify will always have a correct receiver with commit Made travis-ci builds fail when unit-tests fail

Pushd also fix Fixed typo ouwerker -> ouwerkerk

Still having problems on thinpower to send E-mail. I see in log/oddb/debug/2014/06.log 

2014-06-02 13:23:53 CESTlog notify Fach- und Patienteninfo Updates (swissmedicinfo.ch): start outgoing process ["log"] 
2014-06-02 11:23:53 UTCUtil.configure_mail deliver_using oddb_yml
2014-06-02 11:23:53 UTC/var/www/oddb.org/src/util/mail.rb: Configured email using "smtp.gmail.com" 587 "admin@ywesee.com"
2014-06-02 11:23:54 UTCUtil.send_mail list_and_recipients ["log"]

I am missing here the log entries for Util.log_and_deliver_mail and log notify hpc.rss: sent mail. Which I got in in oddb-ci2 

2014-06-02 13:29:06 CESTlog notify hpc.rss: start outgoing process ["log"] 
2014-06-02 11:29:06 UTCUtil.configure_mail deliver_using oddb_yml
2014-06-02 11:29:06 UTC/var/www/oddb.org/src/util/mail.rb: Configured email using "smtp.gmail.com" 587 "ngiger@ywesee.com"
2014-06-02 11:29:06 UTCUtil.send_mail list_and_recipients ["log"]
2014-06-02 11:29:06 UTCUtil.log_and_deliver_mail to=["ngiger@ywesee.com"] subject ch.ODDB.org Report - hpc.rss - 06/2014 size New hpc.rss feeds:                 2
This month(6) total:               0
2014-06-02 11:29:07 UTCUtil.log_and_deliver_mail to ["ngiger@ywesee.com"] ch.ODDB.org Report - hpc.rss - 06/2014 res #<Mail::Message:70013177991200, Multipart: false, Headers: <Date: Mon, 02 Jun 2014 13:29:06 +0200>, <From: ngiger@ywesee.com>, <To: ["ngiger@ywesee.com"]>, <Message-ID: <538c60024f6fd_5453fad3676dff4157eb@oddb-ci2.ngiger.dyndns.org.mail>>, <Subject: ch.ODDB.org Report - hpc.rss - 06/2014>, <Mime-Version: 1.0>, <Content-Type: text/plain>, <Content-Transfer-Encoding: 7bit>>
2014-06-02 13:29:08 CESTlog notify hpc.rss: sent mail

Must add a call to pry when sending the e-mail to see the error. Committed Catch and report exceptions while sending mails. This should allow me now to catch errors on thinpowerr.

Two more commits to avoid errors and get more info in case of errors

Finally found the real culprit for my problems sending e-mail. I had an error in the configuration of etc/oddb.yml, where a line - lists: was missing. Corrected it. Pushed a fix to see the error more easily Don't call index if recipient[:lists] is nil

view · edit · sidebar · attach · print · history
Page last modified on June 02, 2014, at 04:46 PM