20140819-fix-fachinfo-search
Summary
- Creating prescription after selecting via trademark search should work
- Make fachinfo search work again
Commits
- https://github.com/ngiger/oddb.org/commit/5b794b4f9ba8dfacc5128ffd79e5fbbf602a0399 Avoid error when running watir-tests
- https://github.com/ngiger/oddb.org/commit/99b3666c5056fcf3494a5b7786f62308a5d18558 Refactoring rezept->prescription
- https://github.com/ngiger/oddb.org/commit/984c2acc4c7f62120198ba6c7dc4e59126453657 Fix visual appearance of prescription.
- https://github.com/ngiger/oddb.org/commit/e94531d3d92209a272c61d3694ea5a57e126d4c6 Added watir test for problem that no drug can be added after a delete-all
- https://github.com/ngiger/oddb.org/commit/545cf06db63cfb46cd5c86fba318cacb477aec04 Finetuning prescription layout. Nicer drug
- https://github.com/ngiger/oddb.org/commit/bcb91a95fda4901d93c22eb7c66443644764a130 Adding forgotton space in prescription
Index
- Creating prescription after selecting via trademark search should work
- Make fachinfo search work again
- Keep in Mind
- Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
- I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
- The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
- One unit-test for searchbar fails and might be a clue why searching does not work correctly.
- Added two skip in test/test_plugin/rss.rb. Why does the mocking not work there anymore?
- Make ext/swissindex/test/test_swissindex.rb and skipping tests in migel-gem pass.
---
Creating prescription after selecting via trademark search should work
- Playing around found also a problem that when starting a prescription using a search by trademark, then adding another drugs via instant seard no second drug was ever added.
Refactored by renaming all names/references of rezept to prescription. See commit Refactoring rezept->prescription.
Some interactions specs failed, but after adding first a test whether an element exists they suddenly pass. (aka bugs in the tests made me loose an hour). Pushed commit Avoid error when running watir-tests
- Interaction search in blocking other processes
Also when running two watir tests in parallel it looks to me that searching for the interaction always blocks also the other thread. Probably searching should be delegated to a separate DRB thread. But here I must investigate closer to get definitive results.
- Visual appearance: I must fix the following visual defaults
- Field Medikament hinzufügen is bold. CSS for element [0, 2] was defined twice, the second time as 'list bold'
- Field Eingabe der ZSR-Nummer: has a non-breaking space in front
- When no ZSR-id is given there are two empty lines between Eingabe der ZSR-Nummer and Stempel, Unterschrift. This can be avoided by adding the component ZsrDetails only when @session.zsr_id is valid.
The last point took much more time and I did not find a easier way than to generate the components, css_map and colspan_maps dynamically in the init method. Pushed commit Fix visual appearance of prescription But things look nice now:
Pushed Added watir test for problem that no drug can be added after a delete-all
Zeno wants to make everything aligned. I think our style sheet do not map correctly our useage. I am removing all 'list' classes from the PrescriptionForm (in src/view/drugs/prescription.rb as it is not a list item.
Discovered how easy it is to manipulate the CSS-classes on the fly with the Chromium developers tool. Maybe I should sit once together with Zeno in the same room. Edit the layout together till everything looks as fine it should, then saving the resulting HTML and adapting the source code later.
With commit Finetuning prescription layout. Nicer drugeverything is neatly aligned to the left. I also added some non-breaking space before and after the drug info. Hope that Zeno will be satisfied.
There were no empty lines in the prescription. Fixed with Adding forgotton space in prescription
Another problem is that after entering a wrong ZSR-ID the form is always reloaded. This is fixed locally. Problem was a trailing '/' at the end which led to continually refreshing the same URL. But I still have to fix the problem that after deleting all medicaments I cannot add a new one. It looks like that in this case the URL is not correctly assembled, neither.