20140915-fix-ajax-search
Summary
- Make extended fachinfo search work again
- Fix sending mails for bsv_xml
Commits
- https://github.com/ngiger/oddb.org/commit/6ce4079564107117da4358a2d438361d38579d0d Another fix for sending mails
- https://github.com/ngiger/oddb.org/commit/ca2f3f21e804a89d7b16f17fdd4561ab3f51f1f2 Fixed tests for sending mails
- https://github.com/ngiger/oddb.org/commit/d8f6383bd0256bfbf2f0a33265231283ad52b06d Fix ajax search
Index
- Keep in Mind
- Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
- I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
- The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
- Searching for Akute myeloische Leukämie via analysen fails
---
Fix sending mails for bsv_xml
Pushed fixes Another fix for sending mails and Fixed tests for sending mails
Make extended fachinfo search work again
The following stuff must be corrected:
- Deleting a drug does not work
- Should selected drugs be visible in the result window?
- Why does simulating clicking the "Suchen" button not work under watir?
- More extensive tests.
Stuff begins to work. Testing manually showed the chapter "Unerwünschte Wirkungen" for Actemra and searching for "Kopfschmerzen", but the selected drug got lost as the URL was http://oddb-ci2.dyndns.org/de/gcc
Clicking "Suchen" in the watir test did not show anything. Breaked and clicked it manually and searching started. After pressing back I did see the URL http://oddb-ci2.dyndns.org/de/gcc/fachinfo_search/ean/7680588680028? with the error message NoMethodError undefined method `gsub!' for #<ODDB::FachinfoDocument2001:0x007f1804395800>
In oddbd output did see
error in SBSM::Session#http_headers: /de/gcc/fachinfo_search/ean/7680588680028? NoMethodError undefined method `gsub!' for #<ODDB::FachinfoDocument2001:0x007f1804395800> /usr/local/lib/ruby/gems/1.9.1/gems/odba-1.1.0/lib/odba/stub.rb:112:in `method_missing' /var/www/oddb.org/src/view/drugs/fachinfo_search.rb:269:in `text' /usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/composite.rb:68:in `create' /usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/composite.rb:286:in `compose_component' /usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/composite.rb:211:in `block in compose'
Fixed this problem. But after pressing the back item the drug Actemra is displayed twice under http://oddb-ci2.dyndns.org/de/gcc/fachinfo_search/ean/7680588680028?
Also when displaying the result for two drugs there is no heading information for each found drug is displayed (URL was http://oddb-ci2.dyndns.org/de/gcc. See
But after pressing back I got the URL http://oddb-ci2.dyndns.org/de/gcc/fachinfo_search/ean/7680588680028,7680576730049? and the info displayed correctly.
Fixed these problems. Adding more watir tests for adding/deleting drugs, deleting all drugs and testing all possible chapter names. Running all watir tests reminded me that I had to fix the delete_all for prescription, too.
Cleaning up my local changes to get rid of way too many puts statements. Waiting for watir tests to complete.
Pushed Fix ajax search
Following watir tests have problem:
- Test for csv-download because paypal does not work on oddb-ci2
- Search for Akute myeloische Leukämie via analysen fails. I will probably attack this problem tomorrow.
Pulled changes on thinpower and restarted ch.oddb services.