20141126-view-pharmacy
Summary
- Adding view for pharmacies
Commits
(in branch medreg)
- https://github.com/ngiger/oddb.org/commit/6d82a291e864f98980f459a4c6f967a3bfbffd8d Various fixes for pharmacies. Remove import of exam in medreg_doctors.
- https://github.com/ngiger/oddb.org/commit/c85dc7dea00a9453839f6ae7691e4965b8341a9d Corrected import medreg_doctor. hc_provider => pharmacy
- https://github.com/ngiger/oddb.org/commit/c8cfd9cf8fe5c14c2fef6d864175678537d313a2 Added watir test for pharmacies
- https://github.com/ngiger/oddb.org/commit/35d87deb3010801e1d05949fe1ddaf21bebeaf9b renamed medreg_company -> medreg_pharmacy
- https://github.com/ngiger/oddb.org/commit/4da4be499fb8beb716955241f91e28a1a2d993d6 Fixed various error in unit-tests
Index
- Keep in Mind
- Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
- I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
- The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
---
Adding view for pharmacies
Searching for pharmacies does not work. Calling jobs/rebuild_indices company_index. Once done searching works, but when displaying a pharmacy I get the error NoMethodError undefined method `collect' for ODDB::BA_type:Class with the following call stack
error in SBSM::Session#to_html: /de/gcc/company/ean/7601001396043 NoMethodError undefined method `collect' for ODDB::BA_type:Class /usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/select.rb:45:in `selection' /usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/select.rb:35:in `block in to_html' (eval):679:in `select' /usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/select.rb:34:in `to_html' /usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/grid.rb:102:in `block in component_html' /usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/grid.rb:100:in `each' /usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/grid.rb:100:in `component_html' /usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/grid.rb:119:in `block in to_html' (eval):1290:in `td' <..>
The same view works when not logged in. Problem is that the admin selection for business_area does not work. Made some correction, now it does display the entry when logged in as admin, but the drop_down select list for business_area is empty.
Links inside the result for http://oddb-ci2.dyndns.org/de/gcc/search/zone/pharmacies/search_query/Glarus? point to http://oddb-ci2.dyndns.org/de/gcc/company/ean/7601001380028 instead of http://oddb-ci2.dyndns.org/de/gcc/pharmacy/ean/7601001380028. Pharmacy displays "Abteilung" which it should not. Link in pharmacy to vcard http://oddb-ci2.dyndns.org/de/gcc/vcard/pharmacy/7601001380028 does not work.
Disabled displaying vcard in list and pharmacy view as we do not provide phone/fax numbers. Corrected error in import_doctor because we cannot determine the year of the exam with the data from medregom. Things look okay now for me. See
Pushed commits:
- Various fixes for pharmacies. Remove import of exam in medreg_doctors.
- Corrected import medreg_doctor. hc_provider => pharmacy
Creating a watir test for pharmacies. Done with commit Added watir test for pharmacies
Rename medreg_companies -> medreg_pharmacies to better reflect it useage. Dropping and reinstalling the database to run the pharmacies import again. Also running test/suite.rb.
Pushed commit
- https://github.com/ngiger/oddb.org/commit/35d87deb3010801e1d05949fe1ddaf21bebeaf9b renamed medreg_company?
- https://github.com/ngiger/oddb.org/commit/4da4be499fb8beb716955241f91e28a1a2d993d6 Fixed various error in unit-tests
Now merging medreg into master branch. Rerunning test. But must fix some tests under test/test_view. Also some spec tests don't run as they should. Having many problems with smoketest as often watir/oddb-ci2 is not ready after executing actions like goto, click.