Index>

20150112-oddbdat-f-80-dat

Summary

• oddb2xml -f 80 dat -a nonpharma
• cleanup evidentia look-and-feel

Commits

• https://github.com/ngiger/oddb.org/commit/313dfeaf49e24c376637c772a143dbff07319ada Use correct css for evidentia. Remove unused lnf
• https://github.com/ngiger/oddb.org/commit/3759025fe53aee31cb0a12d38d198538951fcb51 Removed unused code for mymedi
• https://github.com/ngiger/oddb.org/commit/54bf4602ec6394782ec5fad5406a70434fc6ea4b Disable csv_export for evidentia
• https://github.com/ngiger/oddb.org/commit/6563097fb4c65cca1ad42fa37a8ca1cfd535025c Simplify if only one search_type
• https://github.com/ngiger/oddb.org/commit/95db9c8d624f0844111eb7b1be40fe0e82425296 Avoid nil access
• https://github.com/ngiger/oddb2xml/commit/f4f30d914d1a247fc0ef7a3608065e7747ece095 Moved option parsing to separate file
• https://github.com/ngiger/oddb2xml/commit/1ef3defab13071c24b96c9e52c2e00cf51ebd7f6 Tests use now new Options class
• https://github.com/ngiger/oddb2xml/commit/91f7d4ca1c3692f52b841beb460280682c0168a6 Bumped version to 1.8.10
• https://github.com/ngiger/oddb2xml/commit/6e146516f8a606658a36bebc94980b05f0dcfab5 Added option -r x to increase prices by x percent when generating .dat
• https://github.com/ngiger/oddb2xml/commit/daae7bf0550ae7ad67bb8e65f494a048e14d7c4e Fixed output for (increased) prices in oddb.dat
• https://github.com/ngiger/oddb2xml/commit/3367365da2da868704cb67a441575efe56114705 Reorganized options
• https://github.com/ngiger/oddb2xml/commit/444a2ff45d4626d432b30bdbcaa1703f1a5c1d12 Bumped version to 1.9.0
• https://github.com/ngiger/oddb2xml/commit/3e0fce227b7ccba46234c4e20ac459019fdb28fb Fixed prices for doctor. Added more tests
• https://github.com/ngiger/oddb2xml/commit/baa122c0a5abdbdf94d9e35099d854029edfcb50 Corrected test_options.rb

Index

• oddb2xml -f 80 dat -a nonpharma
• cleanup evidentia look-and-feel

Keep in Mind for work to do in 2015

• Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
• I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
• The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
• search for registration holder like mepha should work. bin/admin works for search_companies('Mepha')
• info registration holder like mepha should should include fields like ydim-i. Mepha (No) and Novartis Ophthalmics AG (Yes, but fields are empty)
• creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
• Display 10 recalls not only those from this month
• Import via data/medreg_companies.yaml

---

• cleanup evidentia look-and-feel

The CSS file for evidentia is http://swiss.mailr.se/css/oddb.css. Must remove lnf for mymedi, mymigel, provita, carenaschweiz and konsuminfo. Done with commit Use correct css for evidentia. Remove unused lnf

Must remove some code which was only used by mymedi. See commit Removed unused code for mymedi

Removed display csv_export with commit Disable csv_export for evidentia

Don't display a select list if only one search_type is enabled. See commit Simplify if only one search_type

One should never, ever push a change before runnning the specs. I did not follow this rule and got punished by real life. There was nil access in my simple change. Fixed with commit Avoid nil access

oddb2xml -f 80 dat -a nonpharma should work

Set set public price for all non-Pharma and non sl prodcuts to ZurRose public price + 80%. I must first test whether optparse allows me to add a optional parameter (80) and a required parameter (dat).

Moved parsing the options into a new class under lib/options.rb and added spec tests for all. Added tests for all options. Cleaned up some unpure code, e.g. opts[:nonpharma] = :true, which should be opts[:nonpharma] = true. See Moved option parsing to separate file. Changed all tests to use the new Options class instead of passing an options hash. See Tests use now new Options class

Found an error in the existing code. When generating *.dat files, many articles have a price of 0 even when we have a ZurRose price and the option -p zurrose is given.

Fixed the problem with commit Added option -r x to increase prices by x percent when generating .dat

Updated history and version with commit Bumped version to 1.8.10.

Running tests. When comparing the output I see, that some prices are not outputted correctly, e.g oddb_with_migel.dat has now 1120020209ERYTHROCIN i.v. Trockensub 1000 mg Ampulle 1 Stk 37616010.03000000000076802025804752 instead of 1120020209ERYTHROCIN i.v. Trockensub 1000 mg Ampulle 1 Stk 0037616010003000000000076802025804752

Fixed this problem with commit Fixed output for (increased) prices in oddb.dat

After discussing with Zeno we decided to simplify the options. Pushed commit

• Reorganized options
• Bumped version to 1.9.0

Now adding a check whether running oddb2xml -a nonpharma -I 80 is really increasing the prices, too.

Zeno tested my changes and remarked, that I had completly misunderstood his intentions. I have to add 80% to the ext_factory and not the public price. Changing tests and implementation. Fixed with commit Fixed prices for doctor. Added more tests

Changed test_options.rb and letting it run. This will take some time. Will continue tomorrow.

Tests looked good. Pushed Corrected test_options.rb