Index>

201502117-new-combined-search

Summary

• Add new combined search
• oddb2xml: Take measure from column M if present

Commits

• https://github.com/ngiger/oddb.org/commit/eabdd5fcbd29e944675f351c038ba616767a6e57 Added titlebar for evidentia
• https://github.com/ngiger/oddb.org/commit/3745cc6ec9edd377d875ab3a36794570329a8dad Fix test/state/global.rb
• https://github.com/ngiger/oddb.org/commit/9ddf533855a93ac804486b717a305899901878b1 Added combined search
• https://github.com/ngiger/oddb.org/commit/cc47cb661ecaf042f8e9243f15ae361f5ff6d71d Place combined search at second place
• https://github.com/ngiger/oddb2xml/commit/bcb2e5536605a32576e54669633d4261ad921d94 Corrected calculation for measure

Index

• Add new combined search
• Change titlebar for evidentia
• oddb2xml: Take measure from column M if present
• add all lines from SwissMedic packages to oddb2xml products

Keep in Mind for work to do

• Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
• I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
• The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
• creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
• Display 10 recalls not only those from this month
• Import via data/medreg_companies.yaml

add all lines from SwissMedic packages to oddb2xml products

Should add into oddb2xml all entries from swissmedic-packages. Also when entries missing in swissindex.

Making some progress. But @packs has very different field names than objects coming from swissindex. Looks like we missed over 5400 entries!

oddb2xml: Take measure from column M if present

Zeno suggested to use for the field measure always the column M from swissmedic. I think we should rethink the meaning, as for Mutagrip (IKSNR 373) I am not sure on how to handle it.

Could improve the recognition. If I cannot determine measure by looking at the name in column_c I take (in this order)

• unit from column L
• description of galenic_form

Now no measure is 'unbekannt'. Pushed commit Corrected calculation for measure

But I still have 33 occurrences of of unknown selling units, e.g. for 7680651850068 "Memantin-Mepha 15 mg, Lactab" or 7680613840014 "Oralair 100 IR und 300 IR, Sublingualtabletten".

Change titlebar for evidentia

The lnf for evidentia should contain a titlebar "evidentia - Wissen und Werkzeuge für Ärzte".

Resolved with commit Added titlebar for evidentia

Add new combined search

Must add a new search

a) first look for price search b) second look for substances

Eg. "Budesonid"

First should come the products with the same ATC-code, then the substances with the same name.

No result should be displayed twice. Results from the price search should be displayed first. (Unsure whether this is easily possible, as I think the results are ordered alphabetically)

Fixed a small error in unit tests with Fix test/state/global.rb

Created (failing) spec test in spec/searchbar_spec.rb.

Creating the combined search was easy. Even when I was unable to add a good unit test via test/test_state/global.rb. There is way too much mocking going on there.

Pushed commit Added combined search

Must place this new search at the second place. Done with commit Place combined search at second place