Index>

201502118-new-combined-search

Summary

• New combined search should not display an item twice

Commits

• https://github.com/ngiger/oddb.org/commit/fec665f37426fe151e78074c5fbe427760cdf736 Fix filtering in combined search
• https://github.com/ngiger/oddb.org/commit/bcc6fe1d4915e298b974f5c2c22b0dfec1e08241 Added jobs/update_rss_feed
• https://github.com/ngiger/oddb2xml/commit/56558baeaa7b3383e69a7d651c042043207a750c Adding missing products from SwissMedic packages.xls for oddb_product.xml
• https://github.com/ngiger/oddb2xml/commit/a1c3737b466ebd513eeef50c80d03839d24a45af Bumped version to 1.9.6
• https://github.com/ngiger/oddb2xml/commit/83c1192c513a474b67643f25ded3794afd74319c Show correct number of created item in oddb_product.xml
• https://github.com/ngiger/oddb2xml/commit/005a0d83be492dc4d3c1ea9aa858a9c2f67a896f Added missing_in_refdata.txt. Skip veterinary

Index

• New combined search should not display an item twice
• add all lines from SwissMedic packages to oddb2xml products
• Make update_rss_feeds job work again. On ch.oddb.org it does not display the correct month eg. January instead of February for price cut.

Keep in Mind for work to do

• Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
• I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
• The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
• creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
• Import via data/medreg_companies.yaml

Make update_rss_feeds job work again. On ch.oddb.org it does not display the correct month eg. January instead of February for price cut.

When I look at http://oddb-ci2.dyndns.org/ I see that I have 15 Preissenkungen SL/LPPV Februar 2015. Whereas on ch.oddb.org I have 35 Preissenkungen SL/LPPV Januar 2015. Why?

Looking at bin/admin on ch.oddb.org shows

ch.oddb> rss_updates["price_cut.rss"]
-> [#<Date: 2015-01-01 ((2457024j,0s,0n),+0s,2299161j)>, 35]

whereas on oddb-ci2.dyndns.org I get

ch.oddb> rss_updates["price_cut.rss"]
-> [#<Date: 2015-02-03 ((2457057j,0s,0n),+0s,2299161j)>, 15]

Added new jobs/update_rss_feeds. Added some debug output when updating the price cut/rise and sl-introduction RSS feeds. Waiting for jobs/update_rss_feeds to finish on oddb-ci2.

Found in log/oddb/debug/2015/02.log

2015-02-18 15:22:17 UTCupdate_rss_feedsname : mont 2015-02-18 today 2015-02-18 with 19 entries
2015-02-18 15:22:22 UTCupdate_rss_feedsname : mont 2015-02-18 today 2015-02-18 with 15 entries
2015-02-18 15:22:24 UTCupdate_rss_feedsname : mont 2015-02-18 today 2015-02-18 with 4 entries

Pushed commit Added jobs/update_rss_feed

Pulled changes to oddb-ci2. After running the job I found in the log

2015-02-18 15:34:49 UTC update_rss_feeds : month 2015-02-18 today 2015-02-18 with 19 entries
2015-02-18 15:34:59 UTC update_rss_feeds : month 2015-02-18 today 2015-02-18 with 15 entries
2015-02-18 15:35:03 UTC update_rss_feeds : month 2015-02-18 today 2015-02-18 with 4 entries

But after reloading http://ch.oddb.org/ I still have 35 Preissenkungen SL/LPPV Januar 2015. Restarting oddbd. Now I get the expected result of 15 Preissenkungen SL/LPPV Februar 2015

add all lines from SwissMedic packages to oddb2xml products

Should add into oddb2xml all entries from swissmedic-packages. Also when entries missing in swissindex.

Making some progress. But @packs has very different field names than objects coming from swissindex. Looks like we missed over 5400 entries! Verified that we really missed many items from packages, e.g. "Cardio-Pulmo-Rénal Sérocytol, suppositoire" or "DONEPEZIL Sandoz Filmtabl 5 mg 50 Stk".

Added a debug field REMARK only in Packages.xlsx, not in swissindex_Pharma_DE.xml in the generated oddb_product.xml. Zeno says, we don't need it. Rearranging builder to pass validation via XSD file, again.

Pushed the following commits:

• Adding missing products from SwissMedic packages.xls for oddb_product.xml
• Bumped version to 1.9.6
• Show correct number of created item in oddb_product.xml

Must remove all veterinary products and produce a file not_in_refdata.txt with EAN and name of product. This eliminates 1379 products. But we still have 19251-15126=4125 more products than before.

Found also some "ad us vet" in oddb_article.xml. Trying to eliminate them, too.

Pushed commit Added missing_in_refdata.txt. Skip veterinary

New combined search should not display an item twice

With the new combined search some items are displayed twice. Eg. http://oddb-ci2.dyndns.org/de/gcc/search/zone/drugs/search_query/Budesonid/search_type/st_combined?#best_result displays twice "Budesonid Sandoz 32". As the ATC code (R01AD05) appears twice. The filtering I introduced yesterday seems not to work correctly.

Fixed with commit Fix filtering in combined search