Index>
20150422-oddb2xml-with-parslet
Summary
- Switch parsing composition for --calc in oddb2xml to use parslet
Commits
Index
- Keep in Mind for work to do
-
- Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
- I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
- The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
- creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
- Import via data/medreg_companies.yaml
- Fix problem with radioactivatum 99m-technetio when parsing Wirkstoffe
Switch parsing composition for --calc in oddb2xml to use parslet
Stuff to do today includes:
- Adapt parsing packages-XLSX to use the new library
- Fix up/lowercase issues for substance names
- Fix the 380 lines that cannot be parsed
- Fix various issues in code and spec tests marked
TODO
- document design and decisions (2 or 3 pages in textile format, giving IKSNR/names for various examples)
- 'ut' -> salts
- what is the meaning of DER?
- shall excipiens and friends be a normal substance? But their quantity "pro" is used for various measures?
- Join the various lines to form correct parts for a composition (using the indexes, Solvens, etc)
- Howto handle stuff like Praeparatio cryodesiccata
- Selling units for 7680611860045 should be 5 and not 12500
- Substance name 7680656280013 for is
Vipera Aspis > 1000 Ld50 Mus and must be corrected to Vipera Aspis > 1000 Ld50 Mus
- IKNSR 7680616310026 does not creat a corret label A
Moved syntax and corresponding specs into separate files with commit Reorganized syntax into a separate file.
Added a link to https://raw.githubusercontent.com/ngiger/oddb2xml/master/lib/oddb2xml/compositions_syntax.rb in dokumentation_calc.textile.
Re-attacking the problem to recognize substance_names like ferrum-quarz 50% or macrogolum 3350.
When looking at all failee lines, I found also some missing units mg/ml, mg/g@ and % m/m@@.
Pushed commits Fix handling substances with names containing D2 or 3350 and Emit more_info and corresp. fields
Now I am having only about 11 errors when running all spec test (see Travis-CI. But there are still about 491 lines giving which are not parsed correctly. Will investigate this next monday.
Pushed commits
Decided to always let travis run all composition tests to track what has to be cleanup up. Number of failing lines is 273, here.
Pushed commit Fixes more border cases