Index>
20150428-oddb2xml-with-parslet
Summary
- Switch parsing composition for --calc in oddb2xml to use parslet
Commits
Index
- Keep in Mind for work to do
-
- Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
- I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
- The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
- creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
- Import via data/medreg_companies.yaml
- Fix problem with radioactivatum 99m-technetio when parsing Wirkstoffe
Switch parsing composition for --calc in oddb2xml to use parslet
Stuff to do today includes:
- handle correctly all occurrences of corresp.
- Fix up/lowercase issues for substance names
- Fix various issues in code and spec tests marked
TODO
- document design and decisions (2 or 3 pages in textile format, giving IKSNR/names for various examples)
- what is the meaning of DER?
- shall excipiens and friends be a normal substance? But their quantity "pro" is used for various measures?
- Howto handle stuff like Praeparatio cryodesiccata
- Selling units for 7680611860045 should be 5 and not 12500
- Substance name 7680656280013 for is
Vipera Aspis > 1000 Ld50 Mus and must be corrected to Vipera Aspis > 1000 Ld50 Mus
- IKNSR 7680616310026 does not creat a corret label A
Still working on making corresp. work correctly. Also simplyfing the syntax, which hopefully should speed up parsing again.
Found out that I can simplify the transformer a lot by using substance_ut.maybe.as(:substance_ut) instead of substance_ut.as(:substance_ut).maybe. Using the first form I can always use the same tranforrmer rule (where each hash-key might be nil). Using the second one needs a transformer rule for each of the combination of non empty values.
Pushed commits
Now I still report 81 entries which do not parse correctly, but in fact there are only 8. Will emit now more information in XML file.