Index>

20150504-desitin-first

Summary

• Product from desitin must come first when using desitin LnF

Commits

• https://github.com/ngiger/oddb.org/commit/91f5e43cac381998cbfa4c47f67f7429544cd1ab Fix unit tests for resultsort
• https://github.com/ngiger/oddb.org/commit/97f6eccdc63498781ba735b5ca27201473d11d67 List desitin products first for Evidentia LnF
• https://github.com/ngiger/oddb.org/commit/25e2b488c1f146d7ff5e638205bed6074dd8e7fc Fix unittest for unchange atc_class
• https://github.com/ngiger/oddb.org/commit/d77371574c7533b653015177fff5818482fa2c97 Desitin after original. Fix sorting of packges with only sl_generic_type

Index

• Product from desitin must come first when using desitin LnF

Keep in Mind for work to do

• Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
• I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
• The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
• creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
• Import via data/medreg_companies.yaml
• Fix problem with radioactivatum 99m-technetio when parsing Wirkstoffe
• Fix galenic_forms when parsing swissmedic.xlsx
• Cleanup generic_type. Replace it everywhere by sl_generic_type and adapt code accordingly.

Product from desitin must come first when using desitin LnF

When the Desitin Look and Feed is enable a search for e.g. levetiracetam http://ch.oddb.org/de/gcc/search/zone/drugs/search_query/levetiracetam/search_type/st_combined?#best_result it should return all desitin products at the top.

Also at the moment the original "Keppra 100 mg/mL" is not displayed at the top, but in the middle. Why?

Fixed an simple error in src/util/resultsort.rb and made test/test_util/resultsort.rb (which had 5 skipped tests) pass with the original test with commit Fix unit tests for resultsort

Now trying to add a unit test for my situation. Done. Pushed commit List desitin products first for Evidentia LnF

Pulled the changes and now all desitin products appear in the front when looking at http://desitin.oddb.org/de/desitin/search/zone/drugs/search_query/Levetiracetam/search_type/st_oddb?#best_result where at ch.oddb.org they still have the old order.

Fixed the unit-tests for the bsp_xml plugin via commit Fix unittest for unchange atc_class.

I think that the BAG-Preparation.xml has wrong entries for "Keppra 100 mg/mL". No, but inside oddb.org we have generic_type and sl_generic_type, which was not take into account properly inside result_sort.rb. Fixed with commit Desitin after original. Fix sorting of packges with only sl_generic_type

Also the client wanted to have the following order of found drugs: 1) original, 2) desitin, 3) other generics.