Index>

20150512-desitin-first

Summary

• Minipack from desitin must come just after originals
• oddb2xml: Use parslet to split column_C of packages into preparation_name and galenic_form

Commits

• https://github.com/ngiger/oddb.org/commit/d27d603a9c316ec6fe59a3f5570974358d088a5f Consider out_of_trade. Prioritize differently for desitin
• https://github.com/ngiger/oddb2xml/commit/eaabe2d1b2fc99e63c410d7a0bc100000122ff4b Separated and improved parsing galenic forms
• https://github.com/ngiger/oddb2xml/commit/5fb9dd5ac79984c61e64f0a4cb3d72668c45b5db Fixed some pending tests. Better handling of galenic_forms
• https://github.com/ngiger/oddb2xml/commit/26d07bb9615c97525b2074433b4f3dcaa9cda706 Bumped version to 2.0.10
• https://github.com/ngiger/oddb2xml/commit/503ff2631696c8f69ba4b4e58c401ec0bca1e14a Correct return parameter for search_galenic_info

Index

• oddb2xml: Use parslet to split column_C of packages into preparation_name and galenic_form
• Minipack from desitin must come just after originals

Keep in Mind for work to do

• Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
• I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
• The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
• creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
• Import via data/medreg_companies.yaml
• Fix problem with radioactivatum 99m-technetio when parsing Wirkstoffe
• Fix galenic_forms when parsing swissmedic.xlsx
• Cleanup generic_type. Replace it everywhere by sl_generic_type and adapt code accordingly.

Minipack from desitin must come just after originals

Must add a unit-test to check correct alphabetical sorting (ignoring digits), as I corrected my regular expression in a wrong way. This works now. Adding more drugs to the test to test the minipacks from desitin (generic_type => :unknown) which must go after generics when not logged in as Desitin and before generics when logged in.

Pushed commit Consider out_of_trade. Prioritize differently for desitin

oddb2xml: Use parslet to split column_C of packages into preparation_name and galenic_form

Integration GalenicFormParser. I have 76 form, which contain a ',' and which ) must handle afterwards to catch cases like

Injektionslösung, anthroposophisches Arzneimitel
zuckerfrei, Kräuterpastillen
25 ug + 50 ug, Tabletten

I will just try, whether I found any of the known galenic_forms inside and assign it. E.g findin Injektionslösung, Pastillen and Tabletten should be good enough.

The column-C is really inconsitent in it meaning, giving sometimes only the name, or name and very specific galenicform, eg. Tabletten retard 20/10 mg. It should really be given in severeal columns, eg. (german/french/italic/english) name of drug, simple galenic form, whereas the composition column should give all the relevant details.

Things begin to look good. Running calc_spec.rb reveals that some galenic_forms are better handled now than before. Converting some previous skipped test in calc_spec.rb to real tests, again. Running oddb2xml --calc to see the differences.

I have 32 empty galenic_forms. See Attach:empty_gal_form.txt. I can emprove on this by looking at the measure.

Now looking at all the differen galenic_form using grep GALENIC_FORM oddb_calc.xml | sort |uniq >tmp.tmp. Found the following questionable lines (of 681)

    <GALENIC_FORM>2 Fertigspritzen</GALENIC_FORM>
    <GALENIC_FORM>i.m.</GALENIC_FORM>
    <GALENIC_FORM>ayurvedisches Arzneimittel</GALENIC_FORM>
    <GALENIC_FORM>tisane laxative, plantes coupées</GALENIC_FORM>
    <GALENIC_FORM>Tonikum</GALENIC_FORM>
    <GALENIC_FORM>topische Lösung</GALENIC_FORM>
    <GALENIC_FORM>Schwamm 10 x 10 x 0,5 cm</GALENIC_FORM>
    <GALENIC_FORM>Schwamm 5 x 5 x 0,5 cm</GALENIC_FORM>
    <GALENIC_FORM>S</GALENIC_FORM>
    <GALENIC_FORM>zuckerfrei</GALENIC_FORM>

Most of the is GIGO (Garbage-In/Garbage-Out).

Pushed commits

• Separated and improved parsing galenic forms
• Fixed some pending tests. Better handling of galenic_forms
• Bumped version to 2.0.10
• Correct return parameter for search_galenic_info