Index>
20150615-oddb2xml-o-fails
Summary
- Running oddb2xml -o fails
Commits
Index
- Keep in Mind for work to do
-
- Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
- I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
- The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
- creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
- Import via data/medreg_companies.yaml
- Fix problem with radioactivatum 99m-technetio when parsing Wirkstoffe
- Fix galenic_forms when parsing swissmedic.xlsx
- Cleanup generic_type. Replace it everywhere by sl_generic_type and adapt code accordingly.
- Get updated ATC-codes from EPha for oddb.org, too.
- Display new fields (LABEL, MORE_INFO, CORRESP) for compositions in oddb.org.
- Use refdatabase for oddb.org, too.
Running oddb2xml -o fails
When runng oddb2xml -o it generates a oddb_fi.xml, but it does not have any entries. No spec tests exist for this case. And this case is not mentioned in test_options.rb, neither. Therefore I don't even know since when this option is broken. When runnning with -o --log I see the message 2015-06-15 08:47:31: SwissmedicInfoExtractor added 0 fachinfo. It looks like extracting fails.
The extracting failed because we had the following problems:
- Using a newer Nokogiri version returns for a CDATA-item directly the item
- SwissMedicInfo contains now authNrs correctly in the XML and no longer in the HTML part (which is fine)
Fixes begin to work. But validating shows, that we never defined elements like KOMPENDIUM_PRODUCT. Looks like that the option -o did not work for a long time!
Building oddb_fi_products.xml fails, because the mon_id cross reference does not work as expected. Why? Reworked loop to find the needed information for oddb_fi_product. Unit-tests work again. Running test_options.rb before checking in my commit. Comparing it with an old output I see that for the element @paragraph@ it emits only the text and not the HTML code. This must be corrected!