Index>
20150713-update-compositions
Summary
- Adapt oddb.org to new fields for compositions
Commits
(on branch Wirkstoffe)
Index
- Keep in Mind for work to do
-
- Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
- I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
- The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
- creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
- Import via data/medreg_companies.yaml
- Fix problem with radioactivatum 99m-technetio when parsing Wirkstoffe
- Fix galenic_forms when parsing swissmedic.xlsx
- Cleanup generic_type. Replace it everywhere by sl_generic_type and adapt code accordingly.
- Get updated ATC-codes from EPha for oddb.org, too.
- Display new fields (LABEL, MORE_INFO, CORRESP) for compositions in oddb.org.
- Use refdatabase for oddb.org, too.
- Fix running rspec for new packungen.xlsx in oddb2xml
Adapt oddb.org to new fields for compositions
Continuing work of yesterday. Found out why we had always two substances for Hilfstoffe. But import of yesterday is still running consuming 200% of CPU. Aborting it, dropping DB and restarting it with a fix to to create Hilfsstoffe properly. Problem was that I forgot to add the content of the cell Wirkstoffe when parsing a composition. Added unit tests to properly check for created compositions and active_agents.
Struggling as I continue to create always active_agents twice. Added new helper method get_auxiliary_substance. It is just a real mess that classes in src/model don't work as expected. Must I add first a call to update_substance(name) before I can call create_active_agent(name). Anyway, changes are only visible in bin/admin after restarting oddbd. No. We don't have to call create_active_agent at all, as this leads to an inconsistent state.
Fixed finally this problem and restarted jobs/import_swissmedic_only update_compositions. Will continue tomorrow.