20150812-add-fi-not-found-in-packungen
Summary
- Must display FI for ISKNR 65452: Cefepim Labatec, which has not yet a package
- Display new fields corresp and excipiens
Commits
- https://github.com/ngiger/oddb.org/commit/dac9cbb9ed2a4bf12bb75be18dbe177a684fd212 Create registration if found in text_info
- https://github.com/ngiger/oddb.org/commit/592e7dfc9a6487a02cee8f59321d4c4440a2831a Better test for text_info creating package/seq/pack
- https://github.com/ngiger/oddb.org/commit/4963b4b4a61449b68511e74f1ed21758cd988b5d Fix creating substances
- https://github.com/ngiger/oddb.org/commit/0f8dec3fa939fb88e44c2ef5f9a84facfa05c11a Force reparse import_daily
- https://github.com/ngiger/oddb.org/commit/32456ed773d906810873002f5da09fc9beadc475 Fix updating of fachinfo in import_daily
Index
- Must display FI for ISKNR 65452: Cefepim Labatec, which has not yet a package
- Display new fields corresp and excipiens
- Keep in Mind for work to do
- Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
- I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
- The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
- creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
- Import via data/medreg_companies.yaml
- Fix problem with radioactivatum 99m-technetio when parsing Wirkstoffe
- Fix galenic_forms when parsing swissmedic.xlsx
- Cleanup generic_type. Replace it everywhere by sl_generic_type and adapt code accordingly.
- Get updated ATC-codes from EPha for oddb.org, too.
- Display new fields CORRESP for compositions in oddb.org.
- Use refdatabase for oddb.org, too.
- Fix running rspec for new packungen.xlsx in oddb2xml
Display new fields corresp and excipiens
Running jobs/import_swissmedic_only update_compositions.
When looking at IKSNR 00277 via http://oddb-ci2.dyndns.org/de/gcc/search/zone/drugs/search_query/00277/search_type/st_registration?#best_result I get NoMethodError undefined method `de' for Excipiens pro Suppositorio:ODDB::ActiveAgent. Looks as if the import did not correctly handle the different languages. No. The problem is that ActiveAgents to not have a descriptions field for localized names. Therefore replacing gf.send @session.language by gf.to_s. Now the excipiens is displayed but without a label Excipiens.
While running the import I detected an error, which is corrected now. Dropping and reloading the database before starting the import again. Pushd commit Fix creating substances
The new fields are displayed now. Example is IKSNR 00603 "Hiberix, Stechampulle mit Lyophilisat und Solvens". See 
I dislike the following:
- Compositions should be from top to the bottom and not left to right
- For Wirk- and Hilfstoffe length of the name should be the same
- Corresp and Excipien lack a label.
Must display FI for ISKNR 65452: Cefepim Labatec, which has not yet a package
Registration is crated, company and name_base are wrong. Fixed. But packages.size is still 0. Fixed it. But why do the unit-tests and the real DB have so different behaviour. This is not good at all.
Pushed commit Create registration if found in text_info and Better test for text_info creating package/seq/pack
Zeno remarked that import_daily creates now the registration/sequence/package, but does not update the fachinfo. Looks for me as if the option :reparse must be set to true. Dropping and reimporting the databse and running import_daily confirmed, that this fixes the problem. Pushed commit Force reparse import_daily
This updated too many FI/PI. Therefore committed Fix updating of fachinfo in import_daily