view · edit · sidebar · attach · print · history

Index>

20150907-FI-for-products-without-package

Summary

  • It must be possible to find a product via name (price-comparision) when it does not yet appear in the Packungen.xlsx
  • changes needed for evidentia

Commits

Index

Keep in Mind for work to do
  • Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
  • I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
  • The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
  • creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
  • Import via data/medreg_companies.yaml
  • Fix problem with radioactivatum 99m-technetio when parsing Wirkstoffe
  • Fix galenic_forms when parsing swissmedic.xlsx
  • Cleanup generic_type. Replace it everywhere by sl_generic_type and adapt code accordingly.
  • Get updated ATC-codes from EPha for oddb.org, too.
  • Use refdatabase for oddb.org, too.
  • Check whether we should revert the part which touche src/plugin/text_info.rb of commit 17af82ba4d76a5838683411b260de265531f9e74. We should improve test/stub/oddbapp.rb to work similar for update/pointer as the real oddbapp. In this case we would have a good Stub for plugins. May we need a different stub when working with plugins (which create/modify/destroy ODDB-Objects), when in most other cases a very simple stub is sufficient.

It must be possible to find a product via name (price-comparision) when it does not yet appear in the Packungen.xlsx

As of September 2015 we have the case of ISKNR 65724: Ringerlactate B. Braun/Ringerlactate – Glucose 5% B. Braun (d’après Hartmann) – Ringerlactate sans K. As seen by the E-Mail of September 05 containing 

New/Updates FI from swissmedicinfo.ch
  ISKNR : Fachinfo - DE - Ringerlactat B. Braun/Ringerlactat – Glucose 5% B. Braun (nach Hartmann) – Ringerlactat ohne K

When we display the corresponding registration the link to the FI is not valid. (Displaying FI?). Why?

Running jobs/update_textinfo_swissmedicinfo --target=both --reparse 65724 to see whether I can collect more information. I see many lines like this /var/www/oddb.org/src/plugin/text_info.rb:1200:in `log_error': check_swissmedicno_fi_pi ["oddb.registration.fachinfo.iksnrs do not match authNrs from AipsDownload_latest.xml", "11066", "Fortalis Baume/Balsam", ""]

Looking at first occurence of it with IKSNR 10175. There we find Reinigungstrank Natürlich ad us.vet. Veterinaray products must be silently ignored. This is no longer the case, because the Swissmedic changed their XLSX column order.

Comparing changes between September 2 and September 7 I see that <authNrs>38207</authNrs> changed to <authNrs>38207, 65724</authNrs>. Did I think about this kind of changes before?

Okay, after fixing the problem with the changed column names, we can find the FI via the trademark search. E.g ringerlactat. Pushed the fix Fix column_names and sequence.name_base

But when looking at the sent e-mail, I noticed that the IKSNRS were not correclty parsed. Added a unit test for Zulassungsnummer\nRingerlactat B. Braun/Ringerlactat + Glucose 5% B. Braun: 38207 (Swissmedic).\nRingerlactat ohne K: 65724 (Swissmedic).. Parsing failed because the name contained a 5%.

Fixed with commit Fix typo ISKNR. Fix parsing iksnrs.

changes needed for evidentia

I am looking at the following needs of evidentia. (eg. when looking on oddb-ci2 at Keppra)

The following changes must be implemented by changing the corresponding ruby classes.

Attach:Evidentia_Change_Requests.pdf

  1. Display "Fach-info" (two lines) as header above the FI
  2. Display "Packungs-grösse (two lines) as header above the FI
  3. Move the column "Wirkstoffe" just after "Präparat"
  4. Do not display the link "F" for photos
  5. Display upto 3 Wirkstoffe by name (at the moment only 1), when more display "<nr>Wirkstoffe"
  6. Do not generate a link for "Wirkstoffe"
  7. Remove completely rows (Receipt, PI, Comarketing, et al) shown as empty columns

Fixed the points 3,4,6 with Suppress photo/substance links for evidentia

Fixed Point 2 with Optional break for Zulassungsinhaber and Packungsgrösse (Added the HML entity ­ as optional space).

See

view · edit · sidebar · attach · print · history
Page last modified on September 07, 2015, at 04:21 PM