Index>
20150909-hash-for-oddb2xml-top-elements
Summary
- Add a hash for each top-lelel XML-element when running oddb2xml -e
- The new fields from Packungen.xlsx must be considered
Commits
Index
- Keep in Mind for work to do
-
- Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
- I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
- The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
- creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
- Import via data/medreg_companies.yaml
- Fix problem with radioactivatum 99m-technetio when parsing Wirkstoffe
- Fix galenic_forms when parsing swissmedic.xlsx
- Cleanup generic_type. Replace it everywhere by sl_generic_type and adapt code accordingly.
- Get updated ATC-codes from EPha for oddb.org, too.
- Use refdatabase for oddb.org, too.
- Check whether we should revert the part which touche src/plugin/text_info.rb of commit 17af82ba4d76a5838683411b260de265531f9e74. We should improve test/stub/oddbapp.rb to work similar for update/pointer as the real oddbapp. In this case we would have a good Stub for plugins. May we need a different stub when working with plugins (which create/modify/destroy ODDB-Objects), when in most other cases a very simple stub is sufficient.
The new fields from Packungen.xlsx must be considered
Zeno wants the following information added
- Gentechnisch hergestellte Wirkstoffe
- Kategorie bei Insulinen
- Verz. bei betäubunsmittel-haltigen Präparaten** (a,b,c,d)
Must these fields considered for generating articles/products or are they only valid for the --calc option? No they must be only added to the oddb_article. Added a unit test for a drug and insulin with gentechnic.
Pushed the following commits:
Add a hash for each top-lelel XML-element when running oddb2xml -e
Having problem to regenerate a correct VCR cassette. Debugging downloader_spec.rb. The AipsDownload.xml generated is way too big, why does the automatic removal of unneeded elements not work? Simply. This was not yet implemented, but on my heads TODO list.
Looking for solution to pretty-print the vcr-cassete.json. Found the following snippet @cat file | python -mjson.tool@, which does the job nicely for me.
Using rexml to parse AipsDownload.xml take however way too much time. Therefore I must find a way to use another builder when using the sax-machine to parse the elements.
As filtering the AipsDownload is too time consuming (rexml take 4 seconds to parse a single element) and I don't know howto to create a XML file when using the sax-machine I was looking for an alternative. Zeno suggested to use just the first element of AipsDownload.xml as we use it only for the fachinfo. Therefore replaced it by a manually generated file.
Looking at the remaining 3 error when running the spec. Fixed the remaining errors with commit Fixed unit tests after changed XLSX columns in July 2015
Make travis-ci run faster with commit Use new container infrastructer of travis-ci
Pushed the following commits