Index>

20151102-fi-changelog

Summary

• Port oddb.org to ruby 2.x
• Diff fachinfo

Commits

Index

• Port oddb.org to ruby 2.x
• When a new fachinfo is imported, we should save the differences to the last fachinfo

Keep in Mind for work to do

• Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
• I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
• The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
• creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
• Import via data/medreg_companies.yaml
• Fix problem with radioactivatum 99m-technetio when parsing Wirkstoffe
• Fix galenic_forms when parsing swissmedic.xlsx
• Cleanup generic_type. Replace it everywhere by sl_generic_type and adapt code accordingly.
• Get updated ATC-codes from EPha for oddb.org, too.
• Use refdatabase for oddb.org, too.
• Check whether we should revert the part which touche src/plugin/text_info.rb of commit 17af82ba4d76a5838683411b260de265531f9e74. We should improve test/stub/oddbapp.rb to work similar for update/pointer as the real oddbapp. In this case we would have a good Stub for plugins. May we need a different stub when working with plugins (which create/modify/destroy ODDB-Objects), when in most other cases a very simple stub is sufficient.
• When a logged in admin user changes an atc_code of a product, the corresponding atc_class must update its sequences, too.

Port oddb.org to ruby 2.x

Most unit test for oddb.org pass with ruby 2.0. The failing one seem to affect mostly views. Therefore I would like to first build the infrastructure (based on docker) to really execute oddb.org and to be able to graphically see

When a new fachinfo is imported, we should save the differences to the last fachinfo

Must look why we cannot store Diffie::diff objects via ODBA. Tried to add a unit test to test/test_plugin/text_info_swissmedicinfo.rb. Here it passes without any problem, as it seems to have it recognised as a String and not as a File. Now I see the error in pry after the call to updated_fi.de.add_change_log_item(old_text_de, new_text) in plugin/text_info.rb I get

 Marshal.dump(updated_fi.de.change_log.first)
TypeError: can't dump File
from (pry):7:in `dump'
ODDB::FachinfoDocument::ChangeLogItem

# Stepped till  /var/www/oddb.org/src/plugin/text_info.rb @ line 125 

[3] pry(ODDB::TextInfoPlugin)> new_ti
=> #<ArgumentError: undefined class/module ODDB::Fachinfo::ChangeLogItem>

Okay. Somewhere there must have been an error while adding ODDB::Fachinfo::ChangeLogItem. Okay. Looks like a real silly error. I forgot to rename in oddbapp.rb in _migrate_child_to_utf8 ODDB::Fachinfo::ChangeLogItem to ODDB::FachinfoDocument::ChangeLogItem. One reason more, that we should really git rid of the obsolete code migrating the database to UTF-8. After having corrected this error, I still cannot store the changelog. Trying to remove the ODBA_SERIALIZABLE from the class definition.

Dropping db, the running jobs/update_textinfo_swissmedicinfo --reparse --target=both 51193 54316 to test whether new and change TI work fine. Okay, this works now. Starting the work on adapting the FI-View by adding a link ChangeLog in http://oddb-ci2.dyndns.org/de/gcc/fachinfo/reg/51193 after the link "Print".

Zeno pointed out, that we should remove the possibility to edit the fachinfo (and its chapters) entirely.

The view begin to emit correct debug output, but the fields don't appear correctly. The CSS is wrong and display white instead of yellow green. Will continue tomorrow.