20151103-fi-changelog
Summary
- Port oddb.org to ruby 2.x
- Diff fachinfo
Commits
Index
- Port oddb.org to ruby 2.x
- When a new fachinfo is imported, we should save the differences to the last fachinfo
- Keep in Mind for work to do
- Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
- I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
- The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
- creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
- Import via data/medreg_companies.yaml
- Fix problem with radioactivatum 99m-technetio when parsing Wirkstoffe
- Fix galenic_forms when parsing swissmedic.xlsx
- Cleanup generic_type. Replace it everywhere by sl_generic_type and adapt code accordingly.
- Get updated ATC-codes from EPha for oddb.org, too.
- Use refdatabase for oddb.org, too.
- Check whether we should revert the part which touche src/plugin/text_info.rb of commit 17af82ba4d76a5838683411b260de265531f9e74. We should improve test/stub/oddbapp.rb to work similar for update/pointer as the real oddbapp. In this case we would have a good Stub for plugins. May we need a different stub when working with plugins (which create/modify/destroy ODDB-Objects), when in most other cases a very simple stub is sufficient.
- When a logged in admin user changes an atc_code of a product, the corresponding atc_class must update its sequences, too.
Port oddb.org to ruby 2.x
Most unit test for oddb.org pass with ruby 2.0. The failing one seem to affect mostly views. Therefore I would like to first build the infrastructure (based on docker) to really execute oddb.org and to be able to graphically see
When a new fachinfo is imported, we should save the differences to the last fachinfo
The view http://oddb-ci2.dyndns.org/de/gcc/fachinfo/reg/54316 looks okay now (Must remove the italic class). See: 
Must make the link http://oddb-ci2.dyndns.org/de/gcc/change_log/fachinfo/54316/de work. At the moment I open a new window. Is this okay and do we need a back-tracking, too?
Somehow I don't know how to trigger a new change_log method in state/global.rb when accessing /de/gcc/change_log/fachinfo/51193. Which variables are needed to make this happen. Somehow it goes via util/session.rb. Why does it always trigger :home when the request_paht is /de/gcc/change_log/fachinfo/51193? After adding change_log to util/validator.rb I can begin debugging the failing view. Looks better now. See 
Cleaning up various unit test failures in test/test_view.
Not happy how we present the diff. What I don't like about Diffy is, that you mus pass some of possible options for displaying the text when you create the diff. Eg. I think diff -U 3 would be a far better default than diff -U 1000 for our problem. Also I would like to include the :include_plus_and_minus_in_html to get -/+ signs in the html output. I will rerun the import with the following options
{ :context => 3, :include_plus_and_minus_in_html => true}
Another alternative would be add a custom diff output.
Looking at single change-log item start to work and it has -/+ signs. See 
and 
Dropping the database and running the import-daily to add the new diffs. Will continue tomorrow.