view · edit · sidebar · attach · print · history

Index>

20151104-fi-changelog

Summary

  • Diff fachinfo

Commits

Index

Keep in Mind for work to do
  • Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
  • I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
  • The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
  • creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
  • Import via data/medreg_companies.yaml
  • Fix problem with radioactivatum 99m-technetio when parsing Wirkstoffe
  • Fix galenic_forms when parsing swissmedic.xlsx
  • Cleanup generic_type. Replace it everywhere by sl_generic_type and adapt code accordingly.
  • Get updated ATC-codes from EPha for oddb.org, too.
  • Use refdatabase for oddb.org, too.
  • Check whether we should revert the part which touche src/plugin/text_info.rb of commit 17af82ba4d76a5838683411b260de265531f9e74. We should improve test/stub/oddbapp.rb to work similar for update/pointer as the real oddbapp. In this case we would have a good Stub for plugins. May we need a different stub when working with plugins (which create/modify/destroy ODDB-Objects), when in most other cases a very simple stub is sufficient.
  • When a logged in admin user changes an atc_code of a product, the corresponding atc_class must update its sequences, too.

When a new fachinfo is imported, we should save the differences to the last fachinfo

Must refactor datastructure or state/view to be able to display a nice history and the head of the changelog. In my opinion we should present the following information

  • The name of the drug (textinfo.name)
  • The list of concerned IKSNRs (available via fachinfo.iksnrs, where it is an array of integer). The field iksnrs in the textinfo is a text field
  • The date of publication (field date of textinfo looks has additional information e.g. Stand der Information Juli 2015.
  • The date when the change_log was generated (field time of change_log)
  • The number of changes (can be determined by using $nr=0; registration('55789').fachinfo.de.change_log.first.diff.each_chunk{|x| $nr+=1}; $nr )
  • A link to the details

Must also change the link from de/gcc/change_log/fachinfo/51193/1 to de/gcc/show/fachinfo/51193/diff/2015-10-27.

Changed session, validator and state/global to display /de/gcc/show/fachinfo/51193/diff and /de/gcc/show/fachinfo/51193/diff/2015-10-27 and having a convenient access to the registration via @session.choosen_fachinfo_diff. Now must place all necessary information in these pages. Added a stub/session.rb and using our real custom/lookandfeelwrapper.rb to get a via to_html a good, minimal diff to debug. I am just wondering, why this it not used in other unit tests, as it provides a very good insight into whether the whole setup works or not.

Views begin to look better. Should we change link to "No changes yet" when in a view like de/gcc/fachinfo/reg/51193 there is no change_log yet? Dropped and reloading database to run import with just 1 line of context.

State of the view is here:

Pushed commits Add change_log when updating fachinfo and Show change_log of fachinfo. Fixed many unit tests

Travis-CI still reported issues. After pushing commits and Another try to make unit test finish on travis-ci Travis-CI finally turned green. Next week I have 15 failing watir tests to fix.

view · edit · sidebar · attach · print · history
Page last modified on November 05, 2015, at 10:19 AM