Index>

20151109-rss-feed-fi

Summary

• RSS of fachinfo does not work under chrome. Firefox does not show all changes
• Various cleanup for fachinfo diff
• Fix nil problem in oddb2xml

Commits

• https://github.com/ngiger/oddb.org/commit/1659f2f4814a3ad3a7ea3934065484471762b849 Remove unneeded puts in view/fachinfo
• https://github.com/ngiger/oddb.org/commit/4bb7ab84cb301e197613eb39935ddc55593a3ca0 Use common diff.css for displaying colorized diff
• https://github.com/ngiger/oddb.org/commit/71f5e194a3e217f87510d4460d3ea4dda0618ff7 Use common diff.css for displaying colorized diff for oddb-<color>.css
• https://github.com/ngiger/oddb.org/commit/8d5ef1470c5799f0034cf934d7ced4947207a623 Don't highlight current line as yellow
• https://github.com/ngiger/oddb.org/commit/98c321d849c4274e64a4117e3f1ae22bd18f4cd4 Fix change_log.text for tables
• https://github.com/ngiger/oddb.org/commit/f9e2200e1acdcd53edd0a160f47a9a405e21c12c Fix Watir test for address correction
• https://github.com/ngiger/oddb.org/commit/80fe03199573208d2aaa81c5d7aee092c96b9c33 Fix tel_search unit test
• https://github.com/ngiger/oddb2xml/commit/432812b0fc5a7cba289bb3d8f5b878dcba14f982 Fixed an error when generating oddb_calc.xml and we have no information for a given EAN, eg. 7680653150012

Index

• RSS of fachinfo does not work under chrome. Firefox does not show all changes
• Various cleanup for fachinfo diff
• Fix nil problem in oddb2xml

Keep in Mind for work to do

• Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
• I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
• The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
• creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
• Import via data/medreg_companies.yaml
• Fix problem with radioactivatum 99m-technetio when parsing Wirkstoffe
• Fix galenic_forms when parsing swissmedic.xlsx
• Cleanup generic_type. Replace it everywhere by sl_generic_type and adapt code accordingly.
• Get updated ATC-codes from EPha for oddb.org, too.
• Use refdatabase for oddb.org, too.
• Check whether we should revert the part which touche src/plugin/text_info.rb of commit 17af82ba4d76a5838683411b260de265531f9e74. We should improve test/stub/oddbapp.rb to work similar for update/pointer as the real oddbapp. In this case we would have a good Stub for plugins. May we need a different stub when working with plugins (which create/modify/destroy ODDB-Objects), when in most other cases a very simple stub is sufficient.
• When a logged in admin user changes an atc_code of a product, the corresponding atc_class must update its sequences, too.

Fix nil problem in oddb2xml

It looks as runnig oddb2xml -e throws now an nil error. A client reported

/usr/lib64/ruby/gems/2.2.0/gems/oddb2xml-2.2.5/lib/oddb2xml/builder.rb:742:in `block (2 levels) in build_calc': undefined method `to_array' for nil:NilClass (NoMethodError)
                from /usr/lib64/ruby/gems/2.2.0/gems/oddb2xml-2.2.5/lib/oddb2xml/builder.rb:741:in `each'
                from /usr/lib64/ruby/gems/2.2.0/gems/oddb2xml-2.2.5/lib/oddb2xml/builder.rb:741:in `block in build_calc'
                from /usr/lib64/ruby/2.2.0/csv.rb:1273:in `open'
                from /usr/lib64/ruby/gems/2.2.0/gems/oddb2xml-2.2.5/lib/oddb2xml/builder.rb:739:in `build_calc'
                from /usr/lib64/ruby/gems/2.2.0/gems/oddb2xml-2.2.5/lib/oddb2xml/builder.rb:71:in `to_xml'
                from /usr/lib64/ruby/gems/2.2.0/gems/oddb2xml-2.2.5/lib/oddb2xml/cli.rb:140:in `block in build'
                from /usr/lib64/ruby/gems/2.2.0/gems/oddb2xml-2.2.5/lib/oddb2xml/cli.rb:94:in `each_air'
                from /usr/lib64/ruby/gems/2.2.0/gems/oddb2xml-2.2.5/lib/oddb2xml/cli.rb:94:in `build'
                from /usr/lib64/ruby/gems/2.2.0/gems/oddb2xml-2.2.5/lib/oddb2xml/cli.rb:84:in `run'
                from /usr/lib64/ruby/gems/2.2.0/gems/oddb2xml-2.2.5/bin/oddb2xml:50:in `<top (required)>'
                from /usr/bin/oddb2xml:23:in `load'
                from /usr/bin/oddb2xml:23:in `<main>'

I will try to reproduce the error running oddb2xml --calc. Added a work-around, but somehow it looks that we got an ean13 without any additional information. Okay, it passed and I got one missed EAN key "7680653150012" WITHOUT nil

Pushed commit Fixed an error when generating oddb_calc.xml and we have no information for a given EAN, eg. 7680653150012

Various cleanup for fachinfo diff

Must fix (in this order) the following problems with the fachinfo diff

• Use a common CSS for the diff. It must be possible to be overridden by a specific lnf. I had integrated the css only in the gcc.
• In the diff view the current line should not be yellow.
• Text for tables must be shown. E.g. IKSNR 61320
• Remove field "Änderungen anzeigen", convert whole line into single link
• Correct background for headers (must be same for the whole line)
• Add snapback

Pushed commits Remove unneeded puts in view/fachinfo and Use common diff.css for displaying colorized diff.

Fixed the same problem with oddb-color style Use common diff.css for displaying colorized diff for oddb-<color>.css

Pushed commit Don't highlight current line as yellow

Using Cansartan-61215.yaml to check my conversion to text. Found various problems.

• no newline before chapter headings
• Some Umlauts are wrong, e.g. "älteren"
• Displays only part of table (Patientenzahl mit einem) and this split in two lines, even when in the HTML it is displayed on one line.

Using pry I find that old_fi.effects.paragraphs[17] and old_fi.effects.paragraphs[17].to_s does not work correctly with tables. Looking deeper into the Umlaut problem. Okay. It looks for me that this not really a problem, but stems from the fact that on oddb-ci2 and thinpower we are running Ruby 1.9.0 where sych does not seem to store the generated yaml as an UTF-8 file. This is no longer the case with Ruby 1.9.3 or later.

Fixed the other problem displaying the table. Multicell join all different lines from one cell, to make a meaningfull text.

Reloaded the database, ran import of two IKSNR. Now the diff looks better, and via bin/admin I was able to verify that the text looks indeed good. E.g

ch.oddb> registration('61215').fachinfo.de.effects.to_s[4850..5000]
-> re Mortalität 145 152 0.95 (0.75-1.19) 0.63
nicht tödliche Schlaganfälle 68 93 0.72 (0.53-0.99) 0.04
nicht tödliche Myokardinfarkte 54 47 1.14 (0.77-1.

Running unit- and Watir-tests before pushing commit.

Pushed the following commits

• https://github.com/ngiger/oddb.org/commit/98c321d849c4274e64a4117e3f1ae22bd18f4cd4 Fix change_log.text for tables
• https://github.com/ngiger/oddb.org/commit/f9e2200e1acdcd53edd0a160f47a9a405e21c12c Fix Watir test for address correction
• https://github.com/ngiger/oddb.org/commit/80fe03199573208d2aaa81c5d7aee092c96b9c33 Fix tel_search unit test

RSS of fachinfo does not work under chrome. Firefox does not show all changes

Zeno remarked that the link http://ch.oddb.org/de/gcc/rss/channel/fachinfo.rss did not work with feedly.

On friday November 6 the email talked about 11 neue Fis, rss of firefox only shows 6. Today only 1 FI is shown in ch.oddb.org.

When I visited http://ch.oddb.org/de/gcc/rss/channel/fachinfo.rss with firefox I got many FI displayed going back till 2006.

As I never worked with feedly I started with it today. There was no problem to add all oddb.ch-rss feeds except the fachinfo. Therefore I must fix the view. But first I will work on creating a Watir-Test for all of these feeds.