Index>
20151110-fi-changelog
Summary
- RSS of fachinfo does not work under chrome. Firefox does not show all changes
- Various cleanup for fachinfo diff
- document HtmlGrid
Commits
Index
- Keep in Mind for work to do
-
- Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
- I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
- The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
- creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
- Import via data/medreg_companies.yaml
- Fix problem with radioactivatum 99m-technetio when parsing Wirkstoffe
- Fix galenic_forms when parsing swissmedic.xlsx
- Cleanup generic_type. Replace it everywhere by sl_generic_type and adapt code accordingly.
- Get updated ATC-codes from EPha for oddb.org, too.
- Use refdatabase for oddb.org, too.
- Check whether we should revert the part which touche src/plugin/text_info.rb of commit 17af82ba4d76a5838683411b260de265531f9e74. We should improve test/stub/oddbapp.rb to work similar for update/pointer as the real oddbapp. In this case we would have a good Stub for plugins. May we need a different stub when working with plugins (which create/modify/destroy ODDB-Objects), when in most other cases a very simple stub is sufficient.
- When a logged in admin user changes an atc_code of a product, the corresponding atc_class must update its sequences, too.
Various cleanup for fachinfo diff
Must fix (in this order) the following problems with the fachinfo diff
Views look good now. Snapback seems to work for a single item, but not for the list of changelog. Why? Changing the base class to PrivateTemplate in view/fachinfo_changelogs fixed this problem. Thinking about howto better document htmlgrid.
Pushed commits Reworked changelog list and Fix view changelog_item. Pullling to thinpower and restarting oddbd.
Looks like I got two entries which are essentially the same as seen by bin/admin
ch.oddb> registration('65569').fachinfo.de.change_log[0].diff.to_s.eql?( registration('65569').fachinfo.de.change_log[0].diff.to_s)
-> true
ch.oddb> registration('65569').fachinfo.de.change_log[0].time.eql?( registration('65569').fachinfo.de.change_log[1].time)
-> true
ch.oddb> registration('65569').fachinfo.de.change_log[0].eql?( registration('65569').fachinfo.de.change_log[1])
-> false
Looking in /service/ch.oddb/log/main/current and log/oddb/debug/2015/11.log but found no good clue. Therefore reloading database on oddb-ci2, adding some debug info and restarting import-daily. Also adding comparision function to the Change_log function.
Workaround with logging seems to be okay. Running jobs/update_textinfo_swissmedicinfo --reparse --target=both 65569 twice. Looks for me as if after a reparse the old change_log is gone? Must be looked after tomorrow.
document HtmlGrid
Pushed some commits to start an initial documentation for htmlgrid. See Work without rake. Updated doc. Added hints.textile and Fixed stuff for travis builds
Got rid of never used ruby version and Ruby < 1.9.3 as they don't pass the tests under travis. Pushed commits Try to make it run under Ruby 1.9.2 and Require at least ruby 1.9.3
RSS of fachinfo does not work under chrome. Firefox does not show all changes
Added a test for the rss-feeds when running under firefox.